Move onresize from just Window to Window and elements

Move onresize from just Window to Window and elements

The resize event was added to HTMLMediaElement in http://crbug.com/328140

Add a trailing newline to some files to work around http://crbug.com/307023

Also sync with the list of properties in the latest spec revision.

BUG=330953
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165057

[tkent, 2014-01-14 03:19:22]

https://codereview.chromium.org/136593002/diff/50001/Source/core/dom/Document...
File Source/core/dom/Document.idl (right):

https://codereview.chromium.org/136593002/diff/50001/Source/core/dom/Document...
Source/core/dom/Document.idl:218: // force rebuild: crbug.com/307023
Would you add a blank line at the end of the file and add a comment to the CL
description please?  Having such comment in IDL files doesn't look nice.

https://codereview.chromium.org/136593002/diff/50001/Source/core/dom/GlobalEv...
File Source/core/dom/GlobalEventHandlers.idl (right):

https://codereview.chromium.org/136593002/diff/50001/Source/core/dom/GlobalEv...
Source/core/dom/GlobalEventHandlers.idl:91: //attribute EventHandler ontoggle;
This looks unnecessary.

https://codereview.chromium.org/136593002/diff/50001/Source/core/html/HTMLBod...
File Source/core/html/HTMLBodyElement.idl (right):

https://codereview.chromium.org/136593002/diff/50001/Source/core/html/HTMLBod...
Source/core/html/HTMLBodyElement.idl:40: // force rebuild: crbug.com/307023
This change is unnecessary, right?

https://codereview.chromium.org/136593002/diff/50001/Source/core/html/HTMLFra...
File Source/core/html/HTMLFrameSetElement.idl (right):

https://codereview.chromium.org/136593002/diff/50001/Source/core/html/HTMLFra...
Source/core/html/HTMLFrameSetElement.idl:37: // force rebuild: crbug.com/307023
This change is unnecessary because you add 'onresize' attribute, rigth?

[philipj_slow, 2014-01-14 09:43:20]

https://codereview.chromium.org/136593002/diff/50001/Source/core/dom/Document...
File Source/core/dom/Document.idl (right):

https://codereview.chromium.org/136593002/diff/50001/Source/core/dom/Document...
Source/core/dom/Document.idl:218: // force rebuild: crbug.com/307023
On 2014/01/14 03:19:22, tkent wrote:
> Would you add a blank line at the end of the file and add a comment to the CL
> description please?  Having such comment in IDL files doesn't look nice.

Done. The comment was copied from URL.idl, but I'll leave the original alone
since it was how I figured out what the problem was in the first place.

https://codereview.chromium.org/136593002/diff/50001/Source/core/dom/GlobalEv...
File Source/core/dom/GlobalEventHandlers.idl (right):

https://codereview.chromium.org/136593002/diff/50001/Source/core/dom/GlobalEv...
Source/core/dom/GlobalEventHandlers.idl:91: //attribute EventHandler ontoggle;
On 2014/01/14 03:19:22, tkent wrote:
> This looks unnecessary.

I added it so that the list would match the spec and to make it more likely that
someone enables this if they add support for the toggle event, but if you can
prefer I can remove this and two other commented-out events above.

https://codereview.chromium.org/136593002/diff/50001/Source/core/html/HTMLBod...
File Source/core/html/HTMLBodyElement.idl (right):

https://codereview.chromium.org/136593002/diff/50001/Source/core/html/HTMLBod...
Source/core/html/HTMLBodyElement.idl:40: // force rebuild: crbug.com/307023
On 2014/01/14 03:19:22, tkent wrote:
> This change is unnecessary, right?

Oops, yes, I blindly added it to all implementors of
GlobalEventHandlers/WindowEventHandlers.

https://codereview.chromium.org/136593002/diff/50001/Source/core/html/HTMLFra...
File Source/core/html/HTMLFrameSetElement.idl (right):

https://codereview.chromium.org/136593002/diff/50001/Source/core/html/HTMLFra...
Source/core/html/HTMLFrameSetElement.idl:37: // force rebuild: crbug.com/307023
On 2014/01/14 03:19:22, tkent wrote:
> This change is unnecessary because you add 'onresize' attribute, rigth?

Yes.

[tkent, 2014-01-14 09:57:16]

lgtm

https://codereview.chromium.org/136593002/diff/50001/Source/core/dom/GlobalEv...
File Source/core/dom/GlobalEventHandlers.idl (right):

https://codereview.chromium.org/136593002/diff/50001/Source/core/dom/GlobalEv...
Source/core/dom/GlobalEventHandlers.idl:91: //attribute EventHandler ontoggle;
On 2014/01/14 09:43:20, philipj wrote:
> On 2014/01/14 03:19:22, tkent wrote:
> > This looks unnecessary.
> 
> I added it so that the list would match the spec and to make it more likely
that
> someone enables this if they add support for the toggle event, but if you can
> prefer I can remove this and two other commented-out events above.

You are trying to do two things in single CL.
 - Update event list for the latest WHAWG specification
 - Move resize event
They are related, but you can do them separately.

Many reviewers including me don't like multiple-purpose CLs in general.
Please take care of it though I'm approving this.

[commit-bot: I haz the power, 2014-01-14 09:57:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/philipj@opera.com/136593002/150001

[philipj_slow, 2014-01-14 10:04:40]

https://codereview.chromium.org/136593002/diff/50001/Source/core/dom/GlobalEv...
File Source/core/dom/GlobalEventHandlers.idl (right):

https://codereview.chromium.org/136593002/diff/50001/Source/core/dom/GlobalEv...
Source/core/dom/GlobalEventHandlers.idl:91: //attribute EventHandler ontoggle;
On 2014/01/14 09:57:16, tkent wrote:
> On 2014/01/14 09:43:20, philipj wrote:
> > On 2014/01/14 03:19:22, tkent wrote:
> > > This looks unnecessary.
> > 
> > I added it so that the list would match the spec and to make it more likely
> that
> > someone enables this if they add support for the toggle event, but if you
can
> > prefer I can remove this and two other commented-out events above.
> 
> You are trying to do two things in single CL.
>  - Update event list for the latest WHAWG specification
>  - Move resize event
> They are related, but you can do them separately.
> 
> Many reviewers including me don't like multiple-purpose CLs in general.
> Please take care of it though I'm approving this.
> 

To be clear, do you want me to remove the commented-out events, or just to make
more granular commits in the future?

[tkent, 2014-01-14 10:07:25]

https://codereview.chromium.org/136593002/diff/50001/Source/core/dom/GlobalEv...
File Source/core/dom/GlobalEventHandlers.idl (right):

https://codereview.chromium.org/136593002/diff/50001/Source/core/dom/GlobalEv...
Source/core/dom/GlobalEventHandlers.idl:91: //attribute EventHandler ontoggle;
On 2014/01/14 10:04:40, philipj wrote:
> On 2014/01/14 09:57:16, tkent wrote:
> > On 2014/01/14 09:43:20, philipj wrote:
> > > On 2014/01/14 03:19:22, tkent wrote:
> > > > This looks unnecessary.
> > > 
> > > I added it so that the list would match the spec and to make it more
likely
> > that
> > > someone enables this if they add support for the toggle event, but if you
> can
> > > prefer I can remove this and two other commented-out events above.
> > 
> > You are trying to do two things in single CL.
> >  - Update event list for the latest WHAWG specification
> >  - Move resize event
> > They are related, but you can do them separately.
> > 
> > Many reviewers including me don't like multiple-purpose CLs in general.
> > Please take care of it though I'm approving this.
> > 
> 
> To be clear, do you want me to remove the commented-out events, or just to
make
> more granular commits in the future?

The latter.

[philipj_slow, 2014-01-14 10:09:50]

https://codereview.chromium.org/136593002/diff/50001/Source/core/dom/GlobalEv...
File Source/core/dom/GlobalEventHandlers.idl (right):

https://codereview.chromium.org/136593002/diff/50001/Source/core/dom/GlobalEv...
Source/core/dom/GlobalEventHandlers.idl:91: //attribute EventHandler ontoggle;
On 2014/01/14 10:07:26, tkent wrote:
> On 2014/01/14 10:04:40, philipj wrote:
> > On 2014/01/14 09:57:16, tkent wrote:
> > > On 2014/01/14 09:43:20, philipj wrote:
> > > > On 2014/01/14 03:19:22, tkent wrote:
> > > > > This looks unnecessary.
> > > > 
> > > > I added it so that the list would match the spec and to make it more
> likely
> > > that
> > > > someone enables this if they add support for the toggle event, but if
you
> > can
> > > > prefer I can remove this and two other commented-out events above.
> > > 
> > > You are trying to do two things in single CL.
> > >  - Update event list for the latest WHAWG specification
> > >  - Move resize event
> > > They are related, but you can do them separately.
> > > 
> > > Many reviewers including me don't like multiple-purpose CLs in general.
> > > Please take care of it though I'm approving this.
> > > 
> > 
> > To be clear, do you want me to remove the commented-out events, or just to
> make
> > more granular commits in the future?
> 
> The latter.
> 

Will do!

[commit-bot: I haz the power, 2014-01-14 11:24:37]

Commit queue rejected this change because the description was changed
between the time the change entered the commit queue and the time it
was ready to commit. You can safely check the commit box again.

[commit-bot: I haz the power, 2014-01-14 11:26:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/philipj@opera.com/136593002/150001

[commit-bot: I haz the power, 2014-01-14 11:26:35]

Change committed as 165057