Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Issue 1365923002: Make Document.charset an alias of characterSet, as per spec (Closed)

Created:
5 years, 3 months ago by philipj_slow
Modified:
5 years, 2 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make Document.charset an alias of characterSet, as per spec https://dom.spec.whatwg.org/#interface-document Remove counters DocumentInputEncoding and DocumentCharset, they have fulfilled their purpose as both have been specified as aliases based on the data collected: https://www.w3.org/Bugs/Public/show_bug.cgi?id=27435 https://www.w3.org/Bugs/Public/show_bug.cgi?id=27436 BUG=438392 R=dominicc@chromium.org Committed: https://crrev.com/5a4c2803cbed040ea1afe4d59c316f473607836e Cr-Commit-Position: refs/heads/master@{#351508}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -11 lines) Patch
M third_party/WebKit/Source/core/dom/Document.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Document.idl View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ProcessingInstruction.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/ScriptLoader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.h View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/LinkResource.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLResourcePreloader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/FormSubmission.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/page/PageSerializer.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (3 generated)
philipj_slow
5 years, 3 months ago (2015-09-24 09:37:33 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1365923002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1365923002/1
5 years, 3 months ago (2015-09-24 09:37:52 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/108230)
5 years, 3 months ago (2015-09-24 11:43:01 UTC) #5
dominicc (has gone to gerrit)
On 2015/09/24 at 11:43:01, commit-bot wrote: > Dry run: Try jobs failed on following builders: ...
5 years, 2 months ago (2015-09-28 06:48:09 UTC) #6
philipj_slow
On 2015/09/28 06:48:09, dominicc wrote: > On 2015/09/24 at 11:43:01, commit-bot wrote: > > Dry ...
5 years, 2 months ago (2015-09-28 09:08:21 UTC) #7
chromium-reviews
Gah, sorry. I was wondering why enum 127 was removed, and what's happening with enum ...
5 years, 2 months ago (2015-09-29 00:40:56 UTC) #8
philipj_slow
On 2015/09/29 00:40:56, chromium-reviews wrote: > Gah, sorry. > > I was wondering why enum ...
5 years, 2 months ago (2015-09-29 07:29:32 UTC) #9
dominicc (has gone to gerrit)
lgtm
5 years, 2 months ago (2015-09-30 05:36:23 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1365923002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1365923002/1
5 years, 2 months ago (2015-09-30 05:36:30 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-30 07:24:18 UTC) #13
commit-bot: I haz the power
5 years, 2 months ago (2015-09-30 07:25:12 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5a4c2803cbed040ea1afe4d59c316f473607836e
Cr-Commit-Position: refs/heads/master@{#351508}

Powered by Google App Engine
This is Rietveld 408576698