Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(522)

Issue 1365903002: Fix a leak in CJBig2_Context. (Closed)

Created:
5 years, 3 months ago by Lei Zhang
Modified:
5 years, 3 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix a leak in CJBig2_Context. - Remove dead code - Use unique_ptr BUG=pdfium:202 R=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/01c1e54a506329b36f87b0e37d3b419b70973342

Patch Set 1 : Remove dead code #

Patch Set 2 : CJBig2_Context::decodeFile cannot be reached (please sanity check) #

Total comments: 1

Patch Set 3 : Simplify m_nState #

Patch Set 4 : unique_ptr #

Patch Set 5 : more unique_ptr, fix leak #

Total comments: 2

Patch Set 6 : lint #

Patch Set 7 : rebase #

Patch Set 8 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -162 lines) Patch
M core/src/fxcodec/codec/fx_codec_jbig.cpp View 1 1 chunk +1 line, -2 lines 0 comments Download
M core/src/fxcodec/jbig2/JBig2_Context.h View 1 2 3 4 5 6 7 4 chunks +7 lines, -24 lines 0 comments Download
M core/src/fxcodec/jbig2/JBig2_Context.cpp View 1 2 3 4 5 6 7 23 chunks +54 lines, -136 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Lei Zhang
See individual patch sets.
5 years, 3 months ago (2015-09-24 08:19:33 UTC) #2
Tom Sepez
LGTM https://codereview.chromium.org/1365903002/diff/20001/core/src/fxcodec/jbig2/JBig2_Context.h File core/src/fxcodec/jbig2/JBig2_Context.h (left): https://codereview.chromium.org/1365903002/diff/20001/core/src/fxcodec/jbig2/JBig2_Context.h#oldcode31 core/src/fxcodec/jbig2/JBig2_Context.h:31: #define JBIG2_FILE_STREAM 0 In a type-safe world, this ...
5 years, 3 months ago (2015-09-24 16:44:39 UTC) #3
Lei Zhang
https://codereview.chromium.org/1365903002/diff/80001/core/src/fxcodec/jbig2/JBig2_Context.h File core/src/fxcodec/jbig2/JBig2_Context.h (right): https://codereview.chromium.org/1365903002/diff/80001/core/src/fxcodec/jbig2/JBig2_Context.h#newcode114 core/src/fxcodec/jbig2/JBig2_Context.h:114: bool m_bBufSpecified; On 2015/09/24 16:44:38, Tom Sepez wrote: > ...
5 years, 3 months ago (2015-09-24 19:55:25 UTC) #4
Lei Zhang
5 years, 3 months ago (2015-09-24 19:56:34 UTC) #5
Message was sent while issue was closed.
Committed patchset #8 (id:140001) manually as
01c1e54a506329b36f87b0e37d3b419b70973342 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698