third_party/WebKit/Source/web/TextFinder.cpp - Issue 1365853003: LayoutBox::scrollRectToVisible doesn't respect overflow:hidden property.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/TextFinder.cpp

Issue 1365853003: LayoutBox::scrollRectToVisible doesn't respect overflow:hidden property. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: nits Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/web/TextFinder.cpp

diff --git a/third_party/WebKit/Source/web/TextFinder.cpp b/third_party/WebKit/Source/web/TextFinder.cpp

index 38a96b179bf78f82db5169d91551654766d7ab03..fc1e10c7ecd369f9dc82a4d8c4b8860e217d61d7 100644

--- a/third_party/WebKit/Source/web/TextFinder.cpp

+++ b/third_party/WebKit/Source/web/TextFinder.cpp

@@ -636,7 +636,7 @@ int TextFinder::selectFindMatch(unsigned index, WebRect* selectionRect)

if (!activeMatchBoundingBox.isEmpty()) {

if (m_activeMatch->firstNode() && m_activeMatch->firstNode()->layoutObject()) {

m_activeMatch->firstNode()->layoutObject()->scrollRectToVisible(

- LayoutRect(activeMatchBoundingBox), ScrollAlignment::alignCenterIfNeeded, ScrollAlignment::alignCenterIfNeeded);

+ LayoutRect(activeMatchBoundingBox), ScrollAlignment::alignCenterIfNeeded, ScrollAlignment::alignCenterIfNeeded, UserScroll);

}

// Zoom to the active match.

« no previous file with comments | « third_party/WebKit/Source/platform/scroll/ScrollableArea.cpp ('k') | no next file » | no next file with comments »