third_party/WebKit/Source/core/paint/DeprecatedPaintLayerScrollableArea.h - Issue 1365853003: LayoutBox::scrollRectToVisible doesn't respect overflow:hidden property.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/DeprecatedPaintLayerScrollableArea.h

Issue 1365853003: LayoutBox::scrollRectToVisible doesn't respect overflow:hidden property. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Worked on review comments Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/layout/LayoutTextControlSingleLine.cpp ('K') | « third_party/WebKit/Source/core/layout/LayoutTextControlSingleLine.cpp ('k') | third_party/WebKit/Source/core/paint/DeprecatedPaintLayerScrollableArea.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/paint/DeprecatedPaintLayerScrollableArea.h

diff --git a/third_party/WebKit/Source/core/paint/DeprecatedPaintLayerScrollableArea.h b/third_party/WebKit/Source/core/paint/DeprecatedPaintLayerScrollableArea.h

index 2e1f5af6d47ea0b9f33189f9e567469d5d299396..0e9ddb35d8ad82774165e0c117f71cb0399dfff4 100644

--- a/third_party/WebKit/Source/core/paint/DeprecatedPaintLayerScrollableArea.h

+++ b/third_party/WebKit/Source/core/paint/DeprecatedPaintLayerScrollableArea.h

@@ -180,7 +180,7 @@ public:

// FIXME: We shouldn't allow access to m_overflowRect outside this class.

LayoutRect overflowRect() const { return m_overflowRect; }

- void scrollToPosition(const DoublePoint& scrollPosition, ScrollOffsetClamping = ScrollOffsetUnclamped, ScrollBehavior = ScrollBehaviorInstant);

+ void scrollToPosition(const DoublePoint& scrollPosition, ScrollOffsetClamping = ScrollOffsetUnclamped, ScrollBehavior = ScrollBehaviorInstant, ScrollType = ProgrammaticScroll);

void scrollToOffset(const DoubleSize& scrollOffset, ScrollOffsetClamping clamp = ScrollOffsetUnclamped, ScrollBehavior scrollBehavior = ScrollBehaviorInstant)

{

@@ -245,7 +245,7 @@ public:

bool hitTestResizerInFragments(const DeprecatedPaintLayerFragments&, const HitTestLocation&) const;

- LayoutRect scrollIntoView(const LayoutRect&, const ScrollAlignment& alignX, const ScrollAlignment& alignY) override;

+ LayoutRect scrollIntoView(const LayoutRect&, const ScrollAlignment& alignX, const ScrollAlignment& alignY, ScrollType = ProgrammaticScroll) override;

// Returns true if scrollable area is in the FrameView's collection of scrollable areas. This can

// only happen if we're scrollable, visible to hit test, and do in fact overflow. This means that