third_party/WebKit/Source/core/layout/LayoutTextControlSingleLine.cpp - Issue 1365853003: LayoutBox::scrollRectToVisible doesn't respect overflow:hidden property.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutTextControlSingleLine.cpp

Issue 1365853003: LayoutBox::scrollRectToVisible doesn't respect overflow:hidden property. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed typos Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/frame/RootFrameViewport.h ('K') | « third_party/WebKit/Source/core/layout/LayoutObject.cpp ('k') | third_party/WebKit/Source/core/paint/DeprecatedPaintLayerScrollableArea.h » ('j') | third_party/WebKit/Source/platform/scroll/ScrollableArea.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutTextControlSingleLine.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutTextControlSingleLine.cpp b/third_party/WebKit/Source/core/layout/LayoutTextControlSingleLine.cpp

index 32fbfe5c4488431415cf20f508d4e13f211addd5..436717f2647023a8fa3681b8ee57565b4c0faea5 100644

--- a/third_party/WebKit/Source/core/layout/LayoutTextControlSingleLine.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutTextControlSingleLine.cpp

@@ -359,8 +359,10 @@ PassRefPtr<ComputedStyle> LayoutTextControlSingleLine::createInnerEditorStyle(co

textBlockStyle->setWhiteSpace(PRE);

textBlockStyle->setOverflowWrap(NormalOverflowWrap);

- textBlockStyle->setOverflowX(OHIDDEN);

- textBlockStyle->setOverflowY(OHIDDEN);

+ // Note that although overflowX/Y is set to scroll, the scrollbars will be

+ // hidden by the webkit-scrollbar selector in the default style sheet (html.css).

+ textBlockStyle->setOverflowX(OSCROLL);

skobes 2015/09/30 22:31:14 Do we need these two lines, or is the default (OAU

ymalik 2015/10/01 22:25:31 Yes we need these two lines.OAUTO causes the text

+ textBlockStyle->setOverflowY(OSCROLL);

textBlockStyle->setTextOverflow(textShouldBeTruncated() ? TextOverflowEllipsis : TextOverflowClip);

if (m_desiredInnerEditorLogicalHeight >= 0)