third_party/WebKit/Source/platform/scroll/ScrollableArea.h - Issue 1365853003: LayoutBox::scrollRectToVisible doesn't respect overflow:hidden property.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/scroll/ScrollableArea.h

Issue 1365853003: LayoutBox::scrollRectToVisible doesn't respect overflow:hidden property. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added more tests Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/fast/events/autoscroll-upwards-propagation-overflow-hidden-iframe-body.html ('K') | « third_party/WebKit/Source/core/paint/DeprecatedPaintLayerScrollableArea.cpp ('k') | third_party/WebKit/Source/platform/scroll/ScrollableArea.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/scroll/ScrollableArea.h

diff --git a/third_party/WebKit/Source/platform/scroll/ScrollableArea.h b/third_party/WebKit/Source/platform/scroll/ScrollableArea.h

index e5e706d1aa22b8fdcda37b8245f598093eb0e361..4e95bf073492078861774434dc730f6c65fc14bc 100644

--- a/third_party/WebKit/Source/platform/scroll/ScrollableArea.h

+++ b/third_party/WebKit/Source/platform/scroll/ScrollableArea.h

@@ -94,7 +94,7 @@ public:

// Note, in the case of a Document container, such as FrameView, the output will always be the input rect

// since scrolling it can't change the location of content relative to the document, unlike an overflowing

// element.

- virtual LayoutRect scrollIntoView(const LayoutRect& rectInContent, const ScrollAlignment& alignX, const ScrollAlignment& alignY);

+ virtual LayoutRect scrollIntoView(const LayoutRect& rectInContent, const ScrollAlignment& alignX, const ScrollAlignment& alignY, ScrollType = ProgrammaticScroll);

// Scrolls the area so that the given rect, given in the area's content coordinates, such that it's

// cenetered in the second rect, which is given relative to the area's origin.