Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Side by Side Diff: third_party/WebKit/Source/core/frame/FrameView.h

Issue 1365853003: LayoutBox::scrollRectToVisible doesn't respect overflow:hidden property. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: nits Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 Copyright (C) 1997 Martin Jones (mjones@kde.org) 2 Copyright (C) 1997 Martin Jones (mjones@kde.org)
3 (C) 1998 Waldo Bastian (bastian@kde.org) 3 (C) 1998 Waldo Bastian (bastian@kde.org)
4 (C) 1998, 1999 Torben Weis (weis@kde.org) 4 (C) 1998, 1999 Torben Weis (weis@kde.org)
5 (C) 1999 Lars Knoll (knoll@kde.org) 5 (C) 1999 Lars Knoll (knoll@kde.org)
6 (C) 1999 Antti Koivisto (koivisto@kde.org) 6 (C) 1999 Antti Koivisto (koivisto@kde.org)
7 Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserv ed. 7 Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserv ed.
8 8
9 This library is free software; you can redistribute it and/or 9 This library is free software; you can redistribute it and/or
10 modify it under the terms of the GNU Library General Public 10 modify it under the terms of the GNU Library General Public
(...skipping 343 matching lines...) Expand 10 before | Expand all | Expand 10 after
354 GraphicsLayer* layerForHorizontalScrollbar() const override; 354 GraphicsLayer* layerForHorizontalScrollbar() const override;
355 GraphicsLayer* layerForVerticalScrollbar() const override; 355 GraphicsLayer* layerForVerticalScrollbar() const override;
356 GraphicsLayer* layerForScrollCorner() const override; 356 GraphicsLayer* layerForScrollCorner() const override;
357 int scrollSize(ScrollbarOrientation) const override; 357 int scrollSize(ScrollbarOrientation) const override;
358 bool isScrollCornerVisible() const override; 358 bool isScrollCornerVisible() const override;
359 bool userInputScrollable(ScrollbarOrientation) const override; 359 bool userInputScrollable(ScrollbarOrientation) const override;
360 bool shouldPlaceVerticalScrollbarOnLeft() const override; 360 bool shouldPlaceVerticalScrollbarOnLeft() const override;
361 LayoutRect scrollIntoView( 361 LayoutRect scrollIntoView(
362 const LayoutRect& rectInContent, 362 const LayoutRect& rectInContent,
363 const ScrollAlignment& alignX, 363 const ScrollAlignment& alignX,
364 const ScrollAlignment& alignY) override; 364 const ScrollAlignment& alignY,
365 ScrollType = ProgrammaticScroll) override;
365 366
366 // The window that hosts the FrameView. The FrameView will communicate scrol ls and repaints to the 367 // The window that hosts the FrameView. The FrameView will communicate scrol ls and repaints to the
367 // host window in the window's coordinate space. 368 // host window in the window's coordinate space.
368 HostWindow* hostWindow() const override; 369 HostWindow* hostWindow() const override;
369 370
370 // Returns a clip rect in host window coordinates. Used to clip the blit on a scroll. 371 // Returns a clip rect in host window coordinates. Used to clip the blit on a scroll.
371 IntRect windowClipRect(IncludeScrollbarsInRect = ExcludeScrollbars) const; 372 IntRect windowClipRect(IncludeScrollbarsInRect = ExcludeScrollbars) const;
372 373
373 typedef WillBeHeapHashSet<RefPtrWillBeMember<Widget>> ChildrenWidgetSet; 374 typedef WillBeHeapHashSet<RefPtrWillBeMember<Widget>> ChildrenWidgetSet;
374 375
(...skipping 483 matching lines...) Expand 10 before | Expand all | Expand 10 after
858 static const unsigned visualPixelThreshold = 32 * 32; 859 static const unsigned visualPixelThreshold = 32 * 32;
859 if (m_visuallyNonEmptyPixelCount > visualPixelThreshold) 860 if (m_visuallyNonEmptyPixelCount > visualPixelThreshold)
860 setIsVisuallyNonEmpty(); 861 setIsVisuallyNonEmpty();
861 } 862 }
862 863
863 DEFINE_TYPE_CASTS(FrameView, Widget, widget, widget->isFrameView(), widget.isFra meView()); 864 DEFINE_TYPE_CASTS(FrameView, Widget, widget, widget->isFrameView(), widget.isFra meView());
864 865
865 } // namespace blink 866 } // namespace blink
866 867
867 #endif // FrameView_h 868 #endif // FrameView_h
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/editing/Editor.cpp ('k') | third_party/WebKit/Source/core/frame/FrameView.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698