LayoutBox::scrollRectToVisible doesn't respect overflow:hidden property.

third_party/WebKit/Source/core/layout/LayoutTextControl.cpp

 /**
  * Copyright (C) 2006, 2007 Apple Inc. All rights reserved.
  *           (C) 2008 Torch Mobile Inc. All rights reserved. (http://www.torchmobile.com/)
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
  * Library General Public License for more details.
  *
  * You should have received a copy of the GNU Library General Public License
  * along with this library; see the file COPYING.LIB.  If not, write to
  * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
  * Boston, MA 02110-1301, USA.
  *
  */
 
 #include "config.h"
 #include "core/layout/LayoutTextControl.h"
 
 #include "core/html/HTMLTextFormControlElement.h"
 #include "core/layout/HitTestResult.h"
 #include "core/layout/LayoutTheme.h"
 #include "core/layout/TextRunConstructor.h"
+#include "core/paint/DeprecatedPaintLayer.h"
 #include "platform/scroll/ScrollbarTheme.h"
 #include "wtf/text/CharacterNames.h"
 
 namespace blink {
 
 LayoutTextControl::LayoutTextControl(HTMLTextFormControlElement* element)
     : LayoutBlockFlow(element)
 {
     ASSERT(element);
 }
@@ skipping 34 matching lines @@
         // We may have set the width and the height in the old style in layout().
         // Reset them now to avoid getting a spurious layout hint.
         innerEditorLayoutObject->mutableStyleRef().setHeight(Length());
         innerEditorLayoutObject->mutableStyleRef().setWidth(Length());
         innerEditorLayoutObject->setStyle(createInnerEditorStyle(styleRef()));
         innerEditor->setNeedsStyleRecalc(SubtreeStyleChange, StyleChangeReasonForTracing::create(StyleChangeReason::Control));
     }
     textFormControlElement()->updatePlaceholderVisibility();
 }
 
+void LayoutTextControl::scrollRectToVisible(const LayoutRect& rect, const ScrollAlignment& alignX, const ScrollAlignment& alignY, bool programmaticScroll)

[bokan, 2015/09/25 22:26:26]

I'm not up to speed on what LayoutObjects LayoutTextControl creates but I
suspect what we'll really want to do is change it so that it doesn't use
overflow:hidden.

+{
+    LayoutRect newRect = rect;
+
+    // Bring the innerEditor into view first because the scrollRectToVisible call
+    // on it skipped it because it has overflow:hidden. See changes made pertaining
+    // to crbug.com/531525.
+    Element* innerEditor = innerEditorElement();
+    if (!innerEditor)
+        return;
+    LayoutBlock* innerEditorLayoutObject = toLayoutBlock(innerEditor->layoutObject());
+    if (innerEditorLayoutObject && innerEditorLayoutObject->hasOverflowClip() && !innerEditorLayoutObject->scrollRestrictedByLineClamp()) {
+        newRect = innerEditorLayoutObject->layer()->scrollableArea()->scrollIntoView(rect, alignX, alignY);
+    }
+    LayoutBox::scrollRectToVisible(newRect, alignX, alignY, programmaticScroll);
+}
+
 static inline void updateUserModifyProperty(HTMLTextFormControlElement& node, ComputedStyle& style)
 {
     style.setUserModify(node.isDisabledOrReadOnly() ? READ_ONLY : READ_WRITE_PLAINTEXT_ONLY);
 }
 
 void LayoutTextControl::adjustInnerEditorStyle(ComputedStyle& textBlockStyle) const
 {
     // The inner block, if present, always has its direction set to LTR,
     // so we need to inherit the direction and unicode-bidi style from the element.
     textBlockStyle.setDirection(style()->direction());
@@ skipping 198 matching lines @@
     HTMLElement* placeholder = toHTMLTextFormControlElement(node())->placeholderElement();
     LayoutObject* placeholderLayoutObject = placeholder ? placeholder->layoutObject() : nullptr;
     if (!placeholderLayoutObject)
         return nullptr;
     if (relayoutChildren)
         layoutScope.setChildNeedsLayout(placeholderLayoutObject);
     return placeholderLayoutObject;
 }
 
 } // namespace blink