third_party/WebKit/Source/core/layout/LayoutBox.h - Issue 1365853003: LayoutBox::scrollRectToVisible doesn't respect overflow:hidden property.

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutBox.h

Issue 1365853003: LayoutBox::scrollRectToVisible doesn't respect overflow:hidden property. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Handle case when overflow-x:hidden and y:scroll Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/Editor.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutBox.cpp » ('j') | third_party/WebKit/Source/core/layout/LayoutBox.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)	2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)

3 * (C) 1999 Antti Koivisto (koivisto@kde.org)	3 * (C) 1999 Antti Koivisto (koivisto@kde.org)

4 * Copyright (C) 2003, 2006, 2007 Apple Inc. All rights reserved.	4 * Copyright (C) 2003, 2006, 2007 Apple Inc. All rights reserved.

5 *	5 *

6 * This library is free software; you can redistribute it and/or	6 * This library is free software; you can redistribute it and/or

7 * modify it under the terms of the GNU Library General Public	7 * modify it under the terms of the GNU Library General Public

8 * License as published by the Free Software Foundation; either	8 * License as published by the Free Software Foundation; either

9 * version 2 of the License, or (at your option) any later version.	9 * version 2 of the License, or (at your option) any later version.

10 *	10 *

(...skipping 316 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
327 virtual LayoutUnit scrollTop() const;	327 virtual LayoutUnit scrollTop() const;

328 virtual LayoutUnit scrollWidth() const;	328 virtual LayoutUnit scrollWidth() const;

329 virtual LayoutUnit scrollHeight() const;	329 virtual LayoutUnit scrollHeight() const;

330 int pixelSnappedScrollWidth() const;	330 int pixelSnappedScrollWidth() const;

331 int pixelSnappedScrollHeight() const;	331 int pixelSnappedScrollHeight() const;

332 virtual void setScrollLeft(LayoutUnit);	332 virtual void setScrollLeft(LayoutUnit);

333 virtual void setScrollTop(LayoutUnit);	333 virtual void setScrollTop(LayoutUnit);

334	334

335 void scrollToOffset(const DoubleSize&, ScrollBehavior = ScrollBehaviorInstan t);	335 void scrollToOffset(const DoubleSize&, ScrollBehavior = ScrollBehaviorInstan t);

336 void scrollByRecursively(const DoubleSize& delta, ScrollOffsetClamping = Scr ollOffsetUnclamped);	336 void scrollByRecursively(const DoubleSize& delta, ScrollOffsetClamping = Scr ollOffsetUnclamped);

337 void scrollRectToVisible(const LayoutRect&, const ScrollAlignment& alignX, c onst ScrollAlignment& alignY);	337 bool scrollRestrictedByLineClamp() const;

	338 virtual void scrollRectToVisible(const LayoutRect&, const ScrollAlignment& a lignX, const ScrollAlignment& alignY, bool programmaticScroll = true);

338	339

339 LayoutRectOutsets marginBoxOutsets() const override { return m_marginBoxOuts ets; }	340 LayoutRectOutsets marginBoxOutsets() const override { return m_marginBoxOuts ets; }

340 LayoutUnit marginTop() const override { return m_marginBoxOutsets.top(); }	341 LayoutUnit marginTop() const override { return m_marginBoxOutsets.top(); }

341 LayoutUnit marginBottom() const override { return m_marginBoxOutsets.bottom( ); }	342 LayoutUnit marginBottom() const override { return m_marginBoxOutsets.bottom( ); }

342 LayoutUnit marginLeft() const override { return m_marginBoxOutsets.left(); }	343 LayoutUnit marginLeft() const override { return m_marginBoxOutsets.left(); }

343 LayoutUnit marginRight() const override { return m_marginBoxOutsets.right(); }	344 LayoutUnit marginRight() const override { return m_marginBoxOutsets.right(); }

344 void setMarginTop(LayoutUnit margin) { m_marginBoxOutsets.setTop(margin); }	345 void setMarginTop(LayoutUnit margin) { m_marginBoxOutsets.setTop(margin); }

345 void setMarginBottom(LayoutUnit margin) { m_marginBoxOutsets.setBottom(margi n); }	346 void setMarginBottom(LayoutUnit margin) { m_marginBoxOutsets.setBottom(margi n); }

346 void setMarginLeft(LayoutUnit margin) { m_marginBoxOutsets.setLeft(margin); }	347 void setMarginLeft(LayoutUnit margin) { m_marginBoxOutsets.setLeft(margin); }

347 void setMarginRight(LayoutUnit margin) { m_marginBoxOutsets.setRight(margin) ; }	348 void setMarginRight(LayoutUnit margin) { m_marginBoxOutsets.setRight(margin) ; }

(...skipping 589 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
937 if (UNLIKELY(inlineBoxWrapper() != nullptr))	938 if (UNLIKELY(inlineBoxWrapper() != nullptr))

938 deleteLineBoxWrapper();	939 deleteLineBoxWrapper();

939 }	940 }

940	941

941 ensureRareData().m_inlineBoxWrapper = boxWrapper;	942 ensureRareData().m_inlineBoxWrapper = boxWrapper;

942 }	943 }

943	944

944 } // namespace blink	945 } // namespace blink

945	946

946 #endif // LayoutBox_h	947 #endif // LayoutBox_h

OLD	NEW