third_party/WebKit/LayoutTests/fast/css/invalidation/required-optional-pseudo.html - Issue 1365853003: LayoutBox::scrollRectToVisible doesn't respect overflow:hidden property.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/css/invalidation/required-optional-pseudo.html

Issue 1365853003: LayoutBox::scrollRectToVisible doesn't respect overflow:hidden property. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove the now unnecessary code from Patchset 1 Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/css/invalidation/fieldset-disabled-expected.txt ('k') | third_party/WebKit/LayoutTests/fast/css/invalidation/required-optional-pseudo-expected.txt » ('j') | third_party/WebKit/LayoutTests/fast/events/autoscroll-upwards-propagation-overflow-hidden-body.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <script src="../../../resources/js-test.js"></script>	2 <script src="../../../resources/js-test.js"></script>

3 <style>	3 <style>

4 input { background-color: transparent }	4 input { background-color: transparent }

5 #inputOptional:optional,	5 #inputOptional:optional,

6 #inputRequired:required {	6 #inputRequired:required {

7 background-color: green	7 background-color: green

8 }	8 }

9	9

10 input + div {	10 input + div {

(...skipping 13 matching lines...) Expand all Loading...
24 <script>	24 <script>

25 description("Use descendant invalidation sets for :required and :optional pseudo classes.")	25 description("Use descendant invalidation sets for :required and :optional pseudo classes.")

26	26

27 var transparent = "rgba(0, 0, 0, 0)";	27 var transparent = "rgba(0, 0, 0, 0)";

28 var green = "rgb(0, 128, 0)";	28 var green = "rgb(0, 128, 0)";

29	29

30 shouldBe("getComputedStyle(inputOptional, '').backgroundColor", "transparent");	30 shouldBe("getComputedStyle(inputOptional, '').backgroundColor", "transparent");

31 document.body.offsetTop; // Force recalc.	31 document.body.offsetTop; // Force recalc.

32 inputOptional.removeAttribute("required");	32 inputOptional.removeAttribute("required");

33 if (window.internals)	33 if (window.internals)

34 shouldBe("internals.updateStyleAndReturnAffectedElementCount()", "1");	34 shouldBe("internals.updateStyleAndReturnAffectedElementCount()", "3");

35 shouldBe("getComputedStyle(inputOptional, '').backgroundColor", "green");	35 shouldBe("getComputedStyle(inputOptional, '').backgroundColor", "green");

36	36

37 shouldBe("getComputedStyle(inputRequired, '').backgroundColor", "transparent");	37 shouldBe("getComputedStyle(inputRequired, '').backgroundColor", "transparent");

38 document.body.offsetTop; // Force recalc.	38 document.body.offsetTop; // Force recalc.

39 inputRequired.setAttribute("required", "");	39 inputRequired.setAttribute("required", "");

40 if (window.internals)	40 if (window.internals)

41 shouldBe("internals.updateStyleAndReturnAffectedElementCount()", "1");	41 shouldBe("internals.updateStyleAndReturnAffectedElementCount()", "3");

42 shouldBe("getComputedStyle(inputRequired, '').backgroundColor", "green");	42 shouldBe("getComputedStyle(inputRequired, '').backgroundColor", "green");

43	43

44 </script>	44 </script>

OLD	NEW