third_party/WebKit/LayoutTests/fast/css/invalidation/fieldset-disabled.html - Issue 1365853003: LayoutBox::scrollRectToVisible doesn't respect overflow:hidden property.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/css/invalidation/fieldset-disabled.html

Issue 1365853003: LayoutBox::scrollRectToVisible doesn't respect overflow:hidden property. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove the now unnecessary code from Patchset 1 Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/css/invalidation/autofill-pseudo-expected.txt ('k') | third_party/WebKit/LayoutTests/fast/css/invalidation/fieldset-disabled-expected.txt » ('j') | third_party/WebKit/LayoutTests/fast/events/autoscroll-upwards-propagation-overflow-hidden-body.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <script src="../../../resources/js-test.js"></script>	2 <script src="../../../resources/js-test.js"></script>

3 <style>	3 <style>

4 fieldset:disabled { background-color: green }	4 fieldset:disabled { background-color: green }

5 fieldset + div { color: pink }	5 fieldset + div { color: pink }

6 </style>	6 </style>

7 <fieldset id="fieldset">	7 <fieldset id="fieldset">

8 <legend></legend>	8 <legend></legend>

9 <label for="field"></label>	9 <label for="field"></label>

10 <input type="text" name="field" id="field">	10 <input type="text" name="field" id="field">

(...skipping 17 matching lines...) Expand all Loading...
28 var green = "rgb(0, 128, 0)";	28 var green = "rgb(0, 128, 0)";

29	29

30 shouldBe("getComputedStyle(fieldset, '').backgroundColor", "transparent");	30 shouldBe("getComputedStyle(fieldset, '').backgroundColor", "transparent");

31	31

32 fieldset.offsetTop; // Force recalc.	32 fieldset.offsetTop; // Force recalc.

33 fieldset.disabled = true;	33 fieldset.disabled = true;

34	34

35 if (window.internals) {	35 if (window.internals) {

36 // There are still instances of SubtreeStyleChange left when updating	36 // There are still instances of SubtreeStyleChange left when updating

37 // disabled state. This count should become lower.	37 // disabled state. This count should become lower.

38 shouldBe("internals.updateStyleAndReturnAffectedElementCount()", "2");	38 shouldBe("internals.updateStyleAndReturnAffectedElementCount()", "4");

39 }	39 }

40	40

41 shouldBe("getComputedStyle(fieldset, '').backgroundColor", "green");	41 shouldBe("getComputedStyle(fieldset, '').backgroundColor", "green");

42 </script>	42 </script>

OLD	NEW