Never send a referrer header if the referrer is not a web url

Never send a referrer header if the referrer is not a web url

BUG=none
R=abarth@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165085

[abarth-chromium, 2014-01-13 17:14:23]

Test?

Your description states what this change does but not why we're making this
change.  Is there a bug on file related to this change?

[jochen (gone - plz use gerrit), 2014-01-13 19:04:19]

On 2014/01/13 17:14:23, abarth wrote:
> Test?
> 
> Your description states what this change does but not why we're making this
> change.  Is there a bug on file related to this change?

I just came across this while reading the source and found a mismatch between
what generateReferrerHeader and shouldHideReferrer does

Can we have a non-http(s) main frame in layout tests that can access resource on
http? Otherwise I'd add a browser test

[abarth-chromium, 2014-01-13 20:51:42]

On 2014/01/13 19:04:19, jochen wrote:
> Can we have a non-http(s) main frame in layout tests that can access resource
on
> http? Otherwise I'd add a browser test

A browser test (or a unit test) might be easiest.

[jochen (gone - plz use gerrit), 2014-01-14 16:10:10]

ptal

[abarth-chromium, 2014-01-14 18:12:57]

lgtm

Thanks for the test.

[commit-bot: I haz the power, 2014-01-14 18:14:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jochen@chromium.org/136583002/80001

[commit-bot: I haz the power, 2014-01-14 18:31:17]

Change committed as 165085

[tdanderson, 2014-01-14 20:52:05]

A revert of this CL has been created in
https://codereview.chromium.org/133863003/ by tdanderson@chromium.org.

The reason for reverting is: This is the probable cause for the failing browser
test CorrectReferrer. See:

http://build.chromium.org/p/chromium.webkit/builders/Linux%20Tests%20%28dbg%2...

http://build.chromium.org/p/chromium.webkit/builders/Mac10.8%20Tests/builds/5...

http://build.chromium.org/p/chromium.webkit/builders/Win7%20Tests/builds/543/....