Add basic test suite for Blimp

Add basic test suite for Blimp

- Add the BlimpTest target.
- Add a dummy test that runs.

BUG=526219
Committed: https://crrev.com/4ae3272eafeffdc499cc839432dc49689d42a204
Cr-Commit-Position: refs/heads/master@{#350956}

[David Trainor- moved to gerrit, 2015-09-23 23:56:39]

dtrainor@chromium.org changed reviewers:
+ jbudorick@chromium.org, nyquist@chromium.org

[David Trainor- moved to gerrit, 2015-09-23 23:56:39]

ptal thanks!

[nyquist, 2015-09-24 18:15:28]

https://codereview.chromium.org/1365823002/diff/1/blimp/client/BUILD.gn
File blimp/client/BUILD.gn (right):

https://codereview.chromium.org/1365823002/diff/1/blimp/client/BUILD.gn#newco...
blimp/client/BUILD.gn:164: java_files = [
"android/javatests/src/org/chromium/blimp/DummyTest.java" ]
Could you add instructions for how to run this test in the docs?
You might even want to include a simple way of how to filter out to "only" run
this test and possibly how to run a named test-method since that might be
helpful for newcomers to the Android platform. It's easy to get confused on the
format of the command line.

And for now, I guess you should mention the issue with component build as well
and refer to the bug in the doc.

https://codereview.chromium.org/1365823002/diff/1/blimp/client/BUILD.gn#newco...
blimp/client/BUILD.gn:180: instrumentation_test_apk("blimp_test_apk") {
Could you add a new top-level group 'blimp_tests' in //blimp/BUILD.gn that has
deps on this target if is_android?

That way we can always depend on building 'blimp' for prod code, and
'blimp:blimp_tests' for all the tests that are relevant for the current
platform.

[jbudorick, 2015-09-24 18:35:01]

test stuff generally lg

https://codereview.chromium.org/1365823002/diff/1/blimp/client/BUILD.gn
File blimp/client/BUILD.gn (right):

https://codereview.chromium.org/1365823002/diff/1/blimp/client/BUILD.gn#newco...
blimp/client/BUILD.gn:164: java_files = [
"android/javatests/src/org/chromium/blimp/DummyTest.java" ]
On 2015/09/24 at 18:15:28, nyquist wrote:
> Could you add instructions for how to run this test in the docs?
> You might even want to include a simple way of how to filter out to "only" run
this test and possibly how to run a named test-method since that might be
helpful for newcomers to the Android platform. It's easy to get confused on the
format of the command line.
> 

./build/android/adb_install_apk.py $(PRODUCT_DIR)/apks/Blimp.apk
$(PRODUCT_DIR)/bin/run_blimp_test_apk [-f DummyTest.*]

(though the first step will be eliminated Soon(TM))

side question: what parts of the command-line format do you find confusing?

> And for now, I guess you should mention the issue with component build as well
and refer to the bug in the doc.

[nyquist, 2015-09-24 18:47:42]

> side question: what parts of the command-line format do you find confusing?

Where I should put a *, when to include the whole package name instead of just
the class name, whether I should use "." for separating class and method, or if
I should use "#" like one normally does in Java.

[David Trainor- moved to gerrit, 2015-09-25 00:16:29]

https://codereview.chromium.org/1365823002/diff/1/blimp/client/BUILD.gn
File blimp/client/BUILD.gn (right):

https://codereview.chromium.org/1365823002/diff/1/blimp/client/BUILD.gn#newco...
blimp/client/BUILD.gn:164: java_files = [
"android/javatests/src/org/chromium/blimp/DummyTest.java" ]
On 2015/09/24 18:35:01, jbudorick wrote:
> On 2015/09/24 at 18:15:28, nyquist wrote:
> > Could you add instructions for how to run this test in the docs?
> > You might even want to include a simple way of how to filter out to "only"
run
> this test and possibly how to run a named test-method since that might be
> helpful for newcomers to the Android platform. It's easy to get confused on
the
> format of the command line.
> > 
> 
> ./build/android/adb_install_apk.py $(PRODUCT_DIR)/apks/Blimp.apk
> $(PRODUCT_DIR)/bin/run_blimp_test_apk [-f DummyTest.*]
> 
> (though the first step will be eliminated Soon(TM))
> 
> side question: what parts of the command-line format do you find confusing?
> 
> > And for now, I guess you should mention the issue with component build as
well
> and refer to the bug in the doc.

Done.

https://codereview.chromium.org/1365823002/diff/1/blimp/client/BUILD.gn#newco...
blimp/client/BUILD.gn:180: instrumentation_test_apk("blimp_test_apk") {
On 2015/09/24 18:15:28, nyquist wrote:
> Could you add a new top-level group 'blimp_tests' in //blimp/BUILD.gn that has
> deps on this target if is_android?
> 
> That way we can always depend on building 'blimp' for prod code, and
> 'blimp:blimp_tests' for all the tests that are relevant for the current
> platform.

Done.

[nyquist, 2015-09-25 00:31:46]

lgtm

[nyquist, 2015-09-25 02:03:27]

https://codereview.chromium.org/1365823002/diff/20001/blimp/BUILD.gn
File blimp/BUILD.gn (right):

https://codereview.chromium.org/1365823002/diff/20001/blimp/BUILD.gn#newcode16
blimp/BUILD.gn:16: group("blimp_tests") {
Could you add this as a compile target to testing/buildbot/...?
Also, could you add this to the top-level BUILD.gn?

[nyquist, 2015-09-25 02:04:09]

BTW, I'm fine with adding this to the bots as a follow up CL

[David Trainor- moved to gerrit, 2015-09-25 15:45:32]

dtrainor@chromium.org changed reviewers:
+ dpranke@chromium.org

[David Trainor- moved to gerrit, 2015-09-25 15:45:32]

dpranke@ can you take a look at top level BUILD.gn and testing/buildbot/*?

thanks! :)

https://codereview.chromium.org/1365823002/diff/20001/blimp/BUILD.gn
File blimp/BUILD.gn (right):

https://codereview.chromium.org/1365823002/diff/20001/blimp/BUILD.gn#newcode16
blimp/BUILD.gn:16: group("blimp_tests") {
On 2015/09/25 02:03:26, nyquist wrote:
> Could you add this as a compile target to testing/buildbot/...?
> Also, could you add this to the top-level BUILD.gn?

Done.

[Dirk Pranke, 2015-09-25 20:27:29]

https://codereview.chromium.org/1365823002/diff/40001/blimp/BUILD.gn
File blimp/BUILD.gn (right):

https://codereview.chromium.org/1365823002/diff/40001/blimp/BUILD.gn#newcode16
blimp/BUILD.gn:16: group("blimp_tests") {
Should blimp_tests have a dependency on blimp? Presumably eventually you'll need
one, so you could add it now, and then remove the top-level 'blimp' dependency
and the 'blimp' entries from additional_compile_targets in the buildbot files.

https://codereview.chromium.org/1365823002/diff/40001/testing/buildbot/tryser...
File testing/buildbot/tryserver.chromium.linux.json (right):

https://codereview.chromium.org/1365823002/diff/40001/testing/buildbot/tryser...
testing/buildbot/tryserver.chromium.linux.json:122: "blimp_tests",
We shouldn't be adding anything to the linux_chromium_gn bots at this point, now
that the main bots have been flipped over to GN (these bots need to just go
away).

Can you add this to the 'Linux Tests' bot in the chromium.linux file? Then you
won't need to add anything to this file at all (the tryserver will pick up the
steps from the waterfall bot).

[nyquist, 2015-09-25 20:34:30]

https://codereview.chromium.org/1365823002/diff/40001/testing/buildbot/tryser...
File testing/buildbot/tryserver.chromium.linux.json (right):

https://codereview.chromium.org/1365823002/diff/40001/testing/buildbot/tryser...
testing/buildbot/tryserver.chromium.linux.json:122: "blimp_tests",
On 2015/09/25 20:27:29, Dirk Pranke wrote:
> We shouldn't be adding anything to the linux_chromium_gn bots at this point,
now
> that the main bots have been flipped over to GN (these bots need to just go
> away).
> 
> Can you add this to the 'Linux Tests' bot in the chromium.linux file? Then you
> won't need to add anything to this file at all (the tryserver will pick up the
> steps from the waterfall bot).

We would still need it for the android bots, right?

[Dirk Pranke, 2015-09-25 20:39:28]

On 2015/09/25 20:34:30, nyquist wrote:
> We would still need it for the android bots, right?

Right, sorry for not being clear. You still need the android entries.

[David Trainor- moved to gerrit, 2015-09-25 21:50:30]

Is this what you had in mind?

https://codereview.chromium.org/1365823002/diff/40001/blimp/BUILD.gn
File blimp/BUILD.gn (right):

https://codereview.chromium.org/1365823002/diff/40001/blimp/BUILD.gn#newcode16
blimp/BUILD.gn:16: group("blimp_tests") {
On 2015/09/25 20:27:29, Dirk Pranke wrote:
> Should blimp_tests have a dependency on blimp? Presumably eventually you'll
need
> one, so you could add it now, and then remove the top-level 'blimp' dependency
> and the 'blimp' entries from additional_compile_targets in the buildbot files.

Done.

https://codereview.chromium.org/1365823002/diff/40001/testing/buildbot/tryser...
File testing/buildbot/tryserver.chromium.linux.json (right):

https://codereview.chromium.org/1365823002/diff/40001/testing/buildbot/tryser...
testing/buildbot/tryserver.chromium.linux.json:122: "blimp_tests",
On 2015/09/25 20:27:29, Dirk Pranke wrote:
> We shouldn't be adding anything to the linux_chromium_gn bots at this point,
now
> that the main bots have been flipped over to GN (these bots need to just go
> away).
> 
> Can you add this to the 'Linux Tests' bot in the chromium.linux file? Then you
> won't need to add anything to this file at all (the tryserver will pick up the
> steps from the waterfall bot).

Done.

[Dirk Pranke, 2015-09-25 22:09:56]

lgtm

yup, that's what I had in mind.

[David Trainor- moved to gerrit, 2015-09-25 22:27:21]

The CQ bit was checked by dtrainor@chromium.org

[David Trainor- moved to gerrit, 2015-09-25 22:27:21]

The patchset sent to the CQ was uploaded after l-g-t-m from
nyquist@chromium.org, dpranke@chromium.org
Link to the patchset: https://codereview.chromium.org/1365823002/#ps80001
(title: "Forgot to remove blimp_tests from another linux gn bot")

[commit-bot: I haz the power, 2015-09-25 22:28:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1365823002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1365823002/80001

[commit-bot: I haz the power, 2015-09-25 23:36:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-25 23:36:14]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[David Trainor- moved to gerrit, 2015-09-25 23:45:40]

The CQ bit was checked by dtrainor@chromium.org

[commit-bot: I haz the power, 2015-09-25 23:46:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1365823002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1365823002/80001

[commit-bot: I haz the power, 2015-09-26 00:14:19]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-09-26 00:15:06]

Patchset 5 (id:??) landed as
https://crrev.com/4ae3272eafeffdc499cc839432dc49689d42a204
Cr-Commit-Position: refs/heads/master@{#350956}