Make sure links in the profile unlock reauth don't break out of popup.

Make sure links in the profile unlock reauth don't break out of popup.

BUG=528847
Committed: https://crrev.com/0a4d440d08d7c58b3bfda53810f659083ad72edc
Cr-Commit-Position: refs/heads/master@{#351159}

[Roger Tawa OOO till Jul 10th, 2015-09-24 00:26:27]

Patchset #1 (id:1) has been deleted

[Roger Tawa OOO till Jul 10th, 2015-09-24 00:30:40]

rogerta@chromium.org changed reviewers:
+ achuith@chromium.org

[Roger Tawa OOO till Jul 10th, 2015-09-24 00:30:40]

Hi Achuith,

Since this code is shared with cros, can you point me to cros tests so that I
can a test for this change?  Thanks.

[achuithb, 2015-09-28 20:11:48]

lgtm

https://codereview.chromium.org/1365813003/diff/40001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/signin/inline_login_handler_impl.cc (right):

https://codereview.chromium.org/1365813003/diff/40001/chrome/browser/ui/webui...
chrome/browser/ui/webui/signin/inline_login_handler_impl.cc:72: bool
IsUserManagerReauthenticatingProfile(Profile* profile) {
Could you please add a function comment?

Does it make more sense to just call this method IsSystemProfile?

[achuithb, 2015-09-28 20:12:24]

On 2015/09/24 00:30:40, Roger Tawa wrote:
> Hi Achuith,
> 
> Since this code is shared with cros, can you point me to cros tests so that I
> can a test for this change?  Thanks.

Let me take a look. Maybe file a follow-up bug for the test?

[Roger Tawa OOO till Jul 10th, 2015-09-28 20:57:11]

Thanks Achuith.  Created crbug.com/536918 to track tests.

https://codereview.chromium.org/1365813003/diff/40001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/signin/inline_login_handler_impl.cc (right):

https://codereview.chromium.org/1365813003/diff/40001/chrome/browser/ui/webui...
chrome/browser/ui/webui/signin/inline_login_handler_impl.cc:72: bool
IsUserManagerReauthenticatingProfile(Profile* profile) {
On 2015/09/28 20:11:48, achuithb wrote:
> Could you please add a function comment?
> 
> Does it make more sense to just call this method IsSystemProfile?

Done.

[Roger Tawa OOO till Jul 10th, 2015-09-28 21:00:51]

The CQ bit was checked by rogerta@chromium.org

[Roger Tawa OOO till Jul 10th, 2015-09-28 21:00:51]

The patchset sent to the CQ was uploaded after l-g-t-m from achuith@chromium.org
Link to the patchset: https://codereview.chromium.org/1365813003/#ps60001
(title: "Address review comments")

[commit-bot: I haz the power, 2015-09-28 21:04:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1365813003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1365813003/60001

[commit-bot: I haz the power, 2015-09-28 21:18:40]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2015-09-28 21:21:18]

Patchset 3 (id:??) landed as
https://crrev.com/0a4d440d08d7c58b3bfda53810f659083ad72edc
Cr-Commit-Position: refs/heads/master@{#351159}