Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(581)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1365803004: [presubmit] Fix whitespace/semicolon linter violations. (Closed)

Created:
5 years, 2 months ago by Michael Starzinger
Modified:
5 years, 2 months ago
Reviewers:
Benedikt Meurer, Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[presubmit] Fix whitespace/semicolon linter violations. R=bmeurer@chromium.org Committed: https://crrev.com/6a20034d24f39ae3209b1603cfe1cebf95f163fd Cr-Commit-Position: refs/heads/master@{#30963}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -32 lines) Patch
M src/arm64/lithium-codegen-arm64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/base/bits.h View 2 chunks +4 lines, -4 lines 0 comments Download
M src/base/platform/condition-variable.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/debug/debug.h View 1 chunk +1 line, -1 line 0 comments Download
M src/mips64/code-stubs-mips64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips64/macro-assembler-mips64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/objects.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/preparser.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime-date.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/scanner.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/cctest.h View 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/test-api.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M test/cctest/test-code-stubs-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-code-stubs-arm64.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-code-stubs-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-code-stubs-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-code-stubs-mips64.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-code-stubs-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-code-stubs-x87.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-thread-termination.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/types-fuzz.h View 1 chunk +1 line, -2 lines 0 comments Download
M test/unittests/compiler/typer-unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M tools/presubmit.py View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (1 generated)
Michael Starzinger
5 years, 2 months ago (2015-09-25 13:18:00 UTC) #1
Yang
On 2015/09/25 13:18:00, Michael Starzinger wrote: src/debug lgtm
5 years, 2 months ago (2015-09-25 14:07:12 UTC) #2
Benedikt Meurer
LGTM, nice.
5 years, 2 months ago (2015-09-25 16:06:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1365803004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1365803004/1
5 years, 2 months ago (2015-09-28 07:55:24 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-28 08:18:36 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-09-28 08:19:02 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/6a20034d24f39ae3209b1603cfe1cebf95f163fd
Cr-Commit-Position: refs/heads/master@{#30963}

Powered by Google App Engine
This is Rietveld 408576698