Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(561)

Issue 1365763002: Downloads bar for MD: work on sizing, text appearance. (Closed)

Created:
5 years, 3 months ago by Evan Stade
Modified:
5 years, 3 months ago
Reviewers:
sky
CC:
chromium-reviews, asanka, benjhayden+dwatch_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Downloads bar for MD: work on sizing, text appearance. BUG=505804 Committed: https://crrev.com/cf31d9128175cfbaed7ef624dad6a5b22c728d04 Cr-Commit-Position: refs/heads/master@{#350623}

Patch Set 1 #

Patch Set 2 : self review #

Total comments: 8

Patch Set 3 : rebase #

Patch Set 4 : height instead of baseline #

Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -216 lines) Patch
M chrome/browser/ui/views/download/download_item_view_md.h View 1 2 5 chunks +8 lines, -39 lines 0 comments Download
M chrome/browser/ui/views/download/download_item_view_md.cc View 1 2 3 6 chunks +69 lines, -150 lines 0 comments Download
M chrome/browser/ui/views/download/download_shelf_view.cc View 1 6 chunks +51 lines, -27 lines 0 comments Download

Messages

Total messages: 19 (6 generated)
Evan Stade
5 years, 3 months ago (2015-09-23 22:29:16 UTC) #2
sky
https://codereview.chromium.org/1365763002/diff/20001/chrome/browser/ui/views/download/download_item_view_md.cc File chrome/browser/ui/views/download/download_item_view_md.cc (right): https://codereview.chromium.org/1365763002/diff/20001/chrome/browser/ui/views/download/download_item_view_md.cc#newcode70 chrome/browser/ui/views/download/download_item_view_md.cc:70: // All values in dp. do we really use ...
5 years, 3 months ago (2015-09-23 23:42:27 UTC) #3
Evan Stade
https://codereview.chromium.org/1365763002/diff/20001/chrome/browser/ui/views/download/download_item_view_md.cc File chrome/browser/ui/views/download/download_item_view_md.cc (right): https://codereview.chromium.org/1365763002/diff/20001/chrome/browser/ui/views/download/download_item_view_md.cc#newcode70 chrome/browser/ui/views/download/download_item_view_md.cc:70: // All values in dp. On 2015/09/23 23:42:27, sky ...
5 years, 3 months ago (2015-09-24 00:34:26 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1365763002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1365763002/40001
5 years, 3 months ago (2015-09-24 01:02:28 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-24 02:30:34 UTC) #8
sky
https://codereview.chromium.org/1365763002/diff/20001/chrome/browser/ui/views/download/download_item_view_md.cc File chrome/browser/ui/views/download/download_item_view_md.cc (right): https://codereview.chromium.org/1365763002/diff/20001/chrome/browser/ui/views/download/download_item_view_md.cc#newcode323 chrome/browser/ui/views/download/download_item_view_md.cc:323: 2 * kMinimumVerticalPadding + font_list_.GetBaseline() + On 2015/09/24 00:34:26, ...
5 years, 3 months ago (2015-09-24 15:05:53 UTC) #9
Evan Stade
https://codereview.chromium.org/1365763002/diff/20001/chrome/browser/ui/views/download/download_item_view_md.cc File chrome/browser/ui/views/download/download_item_view_md.cc (right): https://codereview.chromium.org/1365763002/diff/20001/chrome/browser/ui/views/download/download_item_view_md.cc#newcode323 chrome/browser/ui/views/download/download_item_view_md.cc:323: 2 * kMinimumVerticalPadding + font_list_.GetBaseline() + On 2015/09/24 15:05:53, ...
5 years, 3 months ago (2015-09-24 17:28:03 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1365763002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1365763002/60001
5 years, 3 months ago (2015-09-24 17:29:56 UTC) #12
sky
LGTM - while you might have noticed descender clipping with english I suspect different languages ...
5 years, 3 months ago (2015-09-24 19:14:49 UTC) #13
Evan Stade
On 2015/09/24 19:14:49, sky wrote: > LGTM - while you might have noticed descender clipping ...
5 years, 3 months ago (2015-09-24 19:21:49 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1365763002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1365763002/60001
5 years, 3 months ago (2015-09-24 19:22:54 UTC) #17
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 3 months ago (2015-09-24 19:47:20 UTC) #18
commit-bot: I haz the power
5 years, 3 months ago (2015-09-24 19:48:09 UTC) #19
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/cf31d9128175cfbaed7ef624dad6a5b22c728d04
Cr-Commit-Position: refs/heads/master@{#350623}

Powered by Google App Engine
This is Rietveld 408576698