Add LayoutTest for "Force update" checkbox of Service Worker

Add LayoutTest for "Force update" checkbox of Service Worker

BUG=500428
Committed: https://crrev.com/a227fbf087ec8f2b231cf994dd7cbb545a402518
Cr-Commit-Position: refs/heads/master@{#351030}

[horo, 2015-09-25 07:46:50]

Patchset #1 (id:1) has been deleted

[horo, 2015-09-25 09:37:00]

horo@chromium.org changed reviewers:
+ ksakamoto@chromium.org

[horo, 2015-09-25 09:37:00]

ksakamoto@

[horo, 2015-09-25 09:37:20]

ksakamoto@
Could you please review this?

[Kunihiko Sakamoto, 2015-09-28 02:27:20]

https://codereview.chromium.org/1365733006/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/http/tests/inspector/service-workers/service-workers-force-update-on-page-load.html
(right):

https://codereview.chromium.org/1365733006/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/inspector/service-workers/service-workers-force-update-on-page-load.html:21:
function waifForWorkerActivated(scope) {
s/waif/wait/

https://codereview.chromium.org/1365733006/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/inspector/service-workers/service-workers-force-update-on-page-load.html:37:
function installNewWorkerDetector(scope) {
I'd prefer to move this and waitForWorkerActivated() out of test() function.

https://codereview.chromium.org/1365733006/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/inspector/service-workers/service-workers-force-update-on-page-load.html:52:
var lastTextContents = "";
Since this saves |textContent|, shouldn't it be named |lastTextContent|?

[horo, 2015-09-28 06:54:57]

https://codereview.chromium.org/1365733006/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/http/tests/inspector/service-workers/service-workers-force-update-on-page-load.html
(right):

https://codereview.chromium.org/1365733006/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/inspector/service-workers/service-workers-force-update-on-page-load.html:21:
function waifForWorkerActivated(scope) {
On 2015/09/28 02:27:19, Kunihiko Sakamoto wrote:
> s/waif/wait/

Done.

https://codereview.chromium.org/1365733006/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/inspector/service-workers/service-workers-force-update-on-page-load.html:37:
function installNewWorkerDetector(scope) {
On 2015/09/28 02:27:19, Kunihiko Sakamoto wrote:
> I'd prefer to move this and waitForWorkerActivated() out of test() function.

They must be in test() function.
This test function is passed to the inspector's environment and evaluated.

https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...

https://codereview.chromium.org/1365733006/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/inspector/service-workers/service-workers-force-update-on-page-load.html:52:
var lastTextContents = "";
On 2015/09/28 02:27:19, Kunihiko Sakamoto wrote:
> Since this saves |textContent|, shouldn't it be named |lastTextContent|?

Done.

[Kunihiko Sakamoto, 2015-09-28 07:00:15]

lgtm

https://codereview.chromium.org/1365733006/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/http/tests/inspector/service-workers/service-workers-force-update-on-page-load.html
(right):

https://codereview.chromium.org/1365733006/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/inspector/service-workers/service-workers-force-update-on-page-load.html:37:
function installNewWorkerDetector(scope) {
On 2015/09/28 06:54:57, horo wrote:
> On 2015/09/28 02:27:19, Kunihiko Sakamoto wrote:
> > I'd prefer to move this and waitForWorkerActivated() out of test() function.
> 
> They must be in test() function.
> This test function is passed to the inspector's environment and evaluated.
> 
>
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...

Ah, got it.

[horo, 2015-09-28 07:01:16]

The CQ bit was checked by horo@chromium.org

[commit-bot: I haz the power, 2015-09-28 07:02:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1365733006/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1365733006/40001

[commit-bot: I haz the power, 2015-09-28 07:48:35]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2015-09-28 07:49:23]

Patchset 2 (id:??) landed as
https://crrev.com/a227fbf087ec8f2b231cf994dd7cbb545a402518
Cr-Commit-Position: refs/heads/master@{#351030}