Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1421)

Unified Diff: components/security_interstitials/core/metrics_helper.h

Issue 1365733005: Split captive portal metrics out of SSLErrorClassification (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Compiler error fix possibly for realsies Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/chrome_browser.gypi ('k') | components/security_interstitials/core/metrics_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/security_interstitials/core/metrics_helper.h
diff --git a/components/security_interstitials/core/metrics_helper.h b/components/security_interstitials/core/metrics_helper.h
index 064a180972407c9d7fa459c10644fdd59ee2a213..e6102017eddf8c4cb541cbb183f9d541fbdbde63 100644
--- a/components/security_interstitials/core/metrics_helper.h
+++ b/components/security_interstitials/core/metrics_helper.h
@@ -91,14 +91,17 @@ class MetricsHelper {
// histogram and potentially in a RAPPOR metric.
void RecordUserDecision(Decision decision);
void RecordUserInteraction(Interaction interaction);
+ void RecordShutdownMetrics();
+
// Number of times user visited this origin before. -1 means not-yet-set.
int NumVisits();
protected:
// Subclasses should implement any embedder-specific recording logic in these
- // methods. They'll be invoked from RecordUserDecision/Interaction.
+ // methods. They'll be invoked from the matching Record methods.
virtual void RecordExtraUserDecisionMetrics(Decision decision) = 0;
virtual void RecordExtraUserInteractionMetrics(Interaction interaction) = 0;
+ virtual void RecordExtraShutdownMetrics() = 0;
private:
// Used to query the HistoryService to see if the URL is in history. It will
« no previous file with comments | « chrome/chrome_browser.gypi ('k') | components/security_interstitials/core/metrics_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698