chrome/browser/interstitials/security_interstitial_page.cc - Issue 1365733005: Split captive portal metrics out of SSLErrorClassification

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/interstitials/security_interstitial_page.cc

Issue 1365733005: Split captive portal metrics out of SSLErrorClassification (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Compiler error fix possibly for realsies Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/interstitials/security_interstitial_page.h ('k') | chrome/browser/safe_browsing/safe_browsing_blocking_page.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/interstitials/security_interstitial_page.cc

diff --git a/chrome/browser/interstitials/security_interstitial_page.cc b/chrome/browser/interstitials/security_interstitial_page.cc

index 876f55b83b31d9e970ac8132d0f862b365f84c5f..0cc658ea333a733bd815a88a075de05fd38bace6 100644

--- a/chrome/browser/interstitials/security_interstitial_page.cc

+++ b/chrome/browser/interstitials/security_interstitial_page.cc

@@ -115,8 +115,8 @@ SecurityInterstitialPage::metrics_helper() const {

}

void SecurityInterstitialPage::set_metrics_helper(

- security_interstitials::MetricsHelper* metrics_helper) {

- metrics_helper_.reset(metrics_helper);

+ scoped_ptr<security_interstitials::MetricsHelper> metrics_helper) {

+ metrics_helper_ = metrics_helper.Pass();

}

base::string16 SecurityInterstitialPage::GetFormattedHostName() const {