components/security_interstitials/core/metrics_helper.cc - Issue 1365733005: Split captive portal metrics out of SSLErrorClassification

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/security_interstitials/core/metrics_helper.cc

Issue 1365733005: Split captive portal metrics out of SSLErrorClassification (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Clean up before review Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ssl/ssl_error_classification.h ('K') | « components/security_interstitials/core/metrics_helper.h ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/security_interstitials/core/metrics_helper.cc

diff --git a/components/security_interstitials/core/metrics_helper.cc b/components/security_interstitials/core/metrics_helper.cc

index da7002bec35e566c8fe37ffae9263592b8888908..7466562841b05856c140b01aa17cef46a6a8cf75 100644

--- a/components/security_interstitials/core/metrics_helper.cc

+++ b/components/security_interstitials/core/metrics_helper.cc

@@ -134,6 +134,10 @@ void MetricsHelper::RecordUserInteraction(Interaction interaction) {

RecordExtraUserInteractionMetrics(interaction);

}

+void MetricsHelper::RecordShutdownMetrics() {

+ RecordExtraShutdownMetrics();

int MetricsHelper::NumVisits() {

return num_visits_;

}