Issue 136573007: Quota: Factor out (Mock)QuotaManagerProxy into its own file for readability

Issue 136573007: Quota: Factor out (Mock)QuotaManagerProxy into its own file for readability (Closed)

Created:
6 years, 11 months ago by nhiroki

Modified:
6 years, 11 months ago

Reviewers:
kinuko, michaeln, jochen (gone - plz use gerrit), tzik

CC:
chromium-reviews, michaeln, jsbell, alecflett, jam, nhiroki, joi+watch-content_chromium.org, darin-cc_chromium.org, cmumford, horo+watch_chromium.org, dgrogan, kinuko+watch, horo

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Quota: Factor out (Mock)QuotaManagerProxy into its own file for readability BUG=n/a TEST=compile (mechanical changes only) TBR=michaeln@chromium.orgjochen@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245533

Patch Set 3 : review fix #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+419 lines, -326 lines)			Patch
M	chrome/browser/browsing_data/browsing_data_quota_helper_unittest.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/chrome_tests_unit.gypi	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	content/browser/fileapi/copy_or_move_operation_delegate_unittest.cc	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	content/browser/fileapi/file_system_operation_impl_unittest.cc	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	content/browser/indexed_db/indexed_db_context_impl.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/renderer_host/database_message_filter.cc	View		2 chunks	+1 line, -1 line	0 comments	Download
M	content/browser/renderer_host/pepper/pepper_file_system_browser_host.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/service_worker/service_worker_context_wrapper.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/service_worker/service_worker_storage.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	content/content_tests.gypi	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	content/public/test/sandbox_file_system_test_helper.cc	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	webkit/browser/appcache/appcache_host.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/browser/appcache/appcache_service.h	View		2 chunks	+1 line, -1 line	0 comments	Download
M	webkit/browser/appcache/appcache_service.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	webkit/browser/appcache/appcache_storage.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/browser/appcache/appcache_storage_impl.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	webkit/browser/appcache/appcache_storage_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/browser/database/database_tracker.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/browser/database/database_tracker_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/browser/fileapi/file_system_context.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/browser/fileapi/file_system_operation_impl.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/browser/fileapi/quota/quota_backend_impl.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/browser/fileapi/quota/quota_backend_impl_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/browser/fileapi/sandbox_file_stream_writer.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/browser/fileapi/sandbox_file_system_backend_delegate.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/browser/fileapi/sandbox_quota_observer.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/browser/quota/mock_quota_manager.h	View		2 chunks	+3 lines, -65 lines	0 comments	Download
M	webkit/browser/quota/mock_quota_manager.cc	View		3 chunks	+0 lines, -54 lines	0 comments	Download
A	webkit/browser/quota/mock_quota_manager_proxy.h	View	1 2	1 chunk	+85 lines, -0 lines	0 comments	Download
A	webkit/browser/quota/mock_quota_manager_proxy.cc	View		1 chunk	+59 lines, -0 lines	0 comments	Download
M	webkit/browser/quota/mock_storage_client.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/browser/quota/quota_manager.h	View		1 chunk	+0 lines, -46 lines	0 comments	Download
M	webkit/browser/quota/quota_manager.cc	View		3 chunks	+1 line, -141 lines	0 comments	Download
A	webkit/browser/quota/quota_manager_proxy.h	View		1 chunk	+78 lines, -0 lines	0 comments	Download
A	webkit/browser/quota/quota_manager_proxy.cc	View		1 chunk	+160 lines, -0 lines	0 comments	Download
M	webkit/browser/quota/quota_manager_unittest.cc	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	webkit/storage_browser.gyp	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

nhiroki

Hi, can you review this? QuotaManager and related components seem a bit tough to read. ...

6 years, 11 months ago (2014-01-17 09:50:10 UTC) #1

tzik

lgtm https://codereview.chromium.org/136573007/diff/60001/webkit/browser/quota/mock_quota_manager_proxy.h File webkit/browser/quota/mock_quota_manager_proxy.h (right): https://codereview.chromium.org/136573007/diff/60001/webkit/browser/quota/mock_quota_manager_proxy.h#newcode79 webkit/browser/quota/mock_quota_manager_proxy.h:79: QuotaClient* registered_client_; could you add DISALLOW_COPY_AND_ASSIGN here?

6 years, 11 months ago (2014-01-17 10:03:56 UTC) #2

kinuko

lgtm https://codereview.chromium.org/136573007/diff/60001/webkit/browser/quota/mock_quota_manager_proxy.h File webkit/browser/quota/mock_quota_manager_proxy.h (right): https://codereview.chromium.org/136573007/diff/60001/webkit/browser/quota/mock_quota_manager_proxy.h#newcode11 webkit/browser/quota/mock_quota_manager_proxy.h:11: #include "webkit/browser/quota/quota_manager.h" not necessary?

6 years, 11 months ago (2014-01-17 11:01:13 UTC) #3

nhiroki

https://codereview.chromium.org/136573007/diff/60001/webkit/browser/quota/mock_quota_manager_proxy.h File webkit/browser/quota/mock_quota_manager_proxy.h (right): https://codereview.chromium.org/136573007/diff/60001/webkit/browser/quota/mock_quota_manager_proxy.h#newcode11 webkit/browser/quota/mock_quota_manager_proxy.h:11: #include "webkit/browser/quota/quota_manager.h" On 2014/01/17 11:01:14, kinuko wrote: > not ...

6 years, 11 months ago (2014-01-17 13:53:54 UTC) #4

nhiroki

Let me use TBR because this is mechanical change only (renaming/adding header files). michaeln@ for ...

6 years, 11 months ago (2014-01-17 13:55:46 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nhiroki@chromium.org/136573007/260001

6 years, 11 months ago (2014-01-17 13:56:23 UTC) #6

Message was sent while issue was closed.

Change committed as 245533

Expand Messages | Collapse Messages