Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1365683003: Blacklist GLVertexAttributesBench and GLVec4ScalarBench for GalaxyS4 due to skia:4373 (Closed)

Created:
5 years, 3 months ago by dogben
Modified:
5 years, 3 months ago
Reviewers:
borenet
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@bl-nanobench
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Blacklist GLVertexAttributesBench and GLVec4ScalarBench for GalaxyS4 due to skia:4373 BUG=skia:4373 Committed: https://skia.googlesource.com/skia/+/3420d2796bad5ce553efb9909790ea72e578dc47

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M tools/nanobench_flags.json View 1 chunk +3 lines, -1 line 0 comments Download
M tools/nanobench_flags.py View 1 chunk +2 lines, -0 lines 0 comments Download

Depends on Patchset:

Issue 1363963002 Patch 1

Messages

Total messages: 7 (2 generated)
dogben
5 years, 3 months ago (2015-09-23 18:42:03 UTC) #2
borenet
LGTM
5 years, 3 months ago (2015-09-23 18:42:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1365683003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1365683003/1
5 years, 3 months ago (2015-09-23 18:44:44 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/3420d2796bad5ce553efb9909790ea72e578dc47
5 years, 3 months ago (2015-09-23 19:20:51 UTC) #6
joshualitt
5 years, 2 months ago (2015-10-01 19:08:57 UTC) #7
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1382933002/ by joshualitt@google.com.

The reason for reverting is: should hopefully be fixed, please reland if not..

Powered by Google App Engine
This is Rietveld 408576698