Issue 1365673003: Fix GrDrawVerticesBatch to work with override colors and eliminate local coords when posssible.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1365673003: Fix GrDrawVerticesBatch to work with override colors and eliminate local coords when posssible. (Closed)

Created:
5 years, 3 months ago by bsalomon

Modified:
5 years, 3 months ago

Reviewers:
joshualitt

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@mangle

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

More Reviews

Description

Fix GrDrawVerticesBatch to work with override colors and eliminate local coords when posssible. Committed: https://skia.googlesource.com/skia/+/14eaaa61ca83ac894934df534b001f4cbeb9eb40

Patch Set 1 #

Patch Set 2 : more #

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+57 lines, -97 lines)			Patch
	M	src/gpu/batches/GrDrawVerticesBatch.h	View		2 chunks	+11 lines, -29 lines	0 comments	Download
	M	src/gpu/batches/GrDrawVerticesBatch.cpp	View	1	8 chunks	+46 lines, -68 lines	0 comments	Download

Depends on Patchset:

Issue 1362873002 Patch 1

Dependent Patchsets:

Issue 1361173003 Patch 1

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1365673003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1365673003/20001

5 years, 3 months ago (2015-09-24 13:56:53 UTC) #5

commit-bot: I haz the power

5 years, 3 months ago (2015-09-24 14:01:29 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/14eaaa61ca83ac894934df534b001f4cbeb9eb40

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages