Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2197)

Unified Diff: runtime/vm/virtual_memory_win.cc

Issue 136563002: Landing: Write protect executable pages in the VM. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/virtual_memory_macos.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/virtual_memory_win.cc
===================================================================
--- runtime/vm/virtual_memory_win.cc (revision 32487)
+++ runtime/vm/virtual_memory_win.cc (working copy)
@@ -8,6 +8,7 @@
#include "vm/virtual_memory.h"
#include "platform/assert.h"
+#include "vm/os.h"
namespace dart {
@@ -63,7 +64,10 @@
}
-bool VirtualMemory::Protect(Protection mode) {
+bool VirtualMemory::Protect(void* address, intptr_t size, Protection mode) {
+ uword start_address = reinterpret_cast<uword>(address);
+ uword end_address = start_address + size;
+ uword page_address = Utils::RoundDown(start_address, PageSize());
DWORD prot = 0;
switch (mode) {
case kNoAccess:
@@ -78,12 +82,13 @@
case kReadExecute:
prot = PAGE_EXECUTE_READ;
break;
- case kReadWriteExecute:
- prot = PAGE_EXECUTE_READWRITE;
- break;
}
DWORD old_prot = 0;
- return VirtualProtect(address(), size(), prot, &old_prot);
+ bool result = VirtualProtect(reinterpret_cast<void*>(page_address),
+ end_address - page_address,
+ prot,
+ &old_prot);
+ return result;
}
} // namespace dart
« no previous file with comments | « runtime/vm/virtual_memory_macos.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698