Landing: Write protect executable pages in the VM.

runtime/vm/virtual_memory_win.cc

Index: runtime/vm/virtual_memory_win.cc
diff --git a/runtime/vm/virtual_memory_win.cc b/runtime/vm/virtual_memory_win.cc
index d1a9277741ad6bfaf55ac8364ed74158f6c3ec19..58efb6d4fa36291d4481f4dc18c8255ee0bf6651 100644
--- a/runtime/vm/virtual_memory_win.cc
+++ b/runtime/vm/virtual_memory_win.cc
@@ -8,6 +8,7 @@
 #include "vm/virtual_memory.h"
 
 #include "platform/assert.h"
+#include "vm/os.h"
 
 namespace dart {
 
@@ -63,7 +64,10 @@ bool VirtualMemory::Commit(uword addr, intptr_t size, bool executable) {
 }
 
 
-bool VirtualMemory::Protect(Protection mode) {
+bool VirtualMemory::Protect(void* address, intptr_t size, Protection mode) {
+  uword start_address = reinterpret_cast<uword>(address);
+  uword end_address = start_address + size;
+  uword page_address = start_address & ~(PageSize() - 1);

[Ivan Posva, 2014/02/03 05:44:35]

ditto

[Florian Schneider, 2014/02/10 11:56:17]

Done.

   DWORD prot = 0;
   switch (mode) {
     case kNoAccess:
@@ -83,7 +87,11 @@ bool VirtualMemory::Protect(Protection mode) {
       break;
   }
   DWORD old_prot = 0;
-  return VirtualProtect(address(), size(), prot, &old_prot);
+  bool result = VirtualProtect(reinterpret_cast<void*>(page_address),
+                        end_address - page_address,
+                        prot,
+                        &old_prot);
+  return result;
 }
 
 }  // namespace dart