Landing: Write protect executable pages in the VM.

runtime/vm/virtual_memory_android.cc

Index: runtime/vm/virtual_memory_android.cc
diff --git a/runtime/vm/virtual_memory_android.cc b/runtime/vm/virtual_memory_android.cc
index 966644dce1c5094c20f36eb4a4391efc6d8c04c5..f26d0995c7c4f25e78b9db045da0fdd55afffe7a 100644
--- a/runtime/vm/virtual_memory_android.cc
+++ b/runtime/vm/virtual_memory_android.cc
@@ -76,7 +76,10 @@ bool VirtualMemory::Commit(uword addr, intptr_t size, bool executable) {
 }
 
 
-bool VirtualMemory::Protect(Protection mode) {
+bool VirtualMemory::Protect(void* address, intptr_t size, Protection mode) {
+  uword start_address = reinterpret_cast<uword>(address);
+  uword end_address = start_address + size;
+  uword page_address = start_address & ~(PageSize() - 1);

[Ivan Posva, 2014/02/03 05:44:35]

How about using RoundDown?

[Florian Schneider, 2014/02/10 11:56:17]

Done.

   int prot = 0;
   switch (mode) {
     case kNoAccess:
@@ -95,7 +98,9 @@ bool VirtualMemory::Protect(Protection mode) {
       prot = PROT_READ | PROT_WRITE | PROT_EXEC;
       break;
   }
-  return (mprotect(address(), size(), prot) == 0);
+  return (mprotect(reinterpret_cast<void*>(page_address),
+                   end_address - page_address,
+                   prot) == 0);
 }
 
 }  // namespace dart