Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1138)

Unified Diff: runtime/vm/virtual_memory_macos.cc

Issue 136563002: Landing: Write protect executable pages in the VM. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Fixed typo and removed debug printing Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/virtual_memory_macos.cc
diff --git a/runtime/vm/virtual_memory_macos.cc b/runtime/vm/virtual_memory_macos.cc
index c99a349e791d79cd59c1d5e18fb902a31e6d0470..34be6de75bae0071963fe853fdb9655a15aabf5e 100644
--- a/runtime/vm/virtual_memory_macos.cc
+++ b/runtime/vm/virtual_memory_macos.cc
@@ -76,7 +76,10 @@ bool VirtualMemory::Commit(uword addr, intptr_t size, bool executable) {
}
-bool VirtualMemory::Protect(Protection mode) {
+bool VirtualMemory::Protect(void* address, intptr_t size, Protection mode) {
+ uword start_address = reinterpret_cast<uword>(address);
+ uword end_address = start_address + size;
+ uword page_address = start_address & ~(PageSize() - 1);
int prot = 0;
switch (mode) {
case kNoAccess:
@@ -95,7 +98,9 @@ bool VirtualMemory::Protect(Protection mode) {
prot = PROT_READ | PROT_WRITE | PROT_EXEC;
break;
}
- return (mprotect(address(), size(), prot) == 0);
+ return (mprotect(reinterpret_cast<void*>(page_address),
+ end_address - page_address,
+ prot) == 0);
}
} // namespace dart

Powered by Google App Engine
This is Rietveld 408576698