Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Side by Side Diff: runtime/vm/virtual_memory_linux.cc

Issue 136563002: Landing: Write protect executable pages in the VM. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/vm/virtual_memory_android.cc ('k') | runtime/vm/virtual_memory_macos.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" 5 #include "vm/globals.h"
6 #if defined(TARGET_OS_LINUX) 6 #if defined(TARGET_OS_LINUX)
7 7
8 #include "vm/virtual_memory.h" 8 #include "vm/virtual_memory.h"
9 9
10 #include <sys/mman.h> // NOLINT 10 #include <sys/mman.h> // NOLINT
(...skipping 58 matching lines...) Expand 10 before | Expand all | Expand 10 after
69 void* address = mmap(reinterpret_cast<void*>(addr), size, prot, 69 void* address = mmap(reinterpret_cast<void*>(addr), size, prot,
70 MAP_PRIVATE | MAP_ANON | MAP_FIXED, 70 MAP_PRIVATE | MAP_ANON | MAP_FIXED,
71 -1, 0); 71 -1, 0);
72 if (address == MAP_FAILED) { 72 if (address == MAP_FAILED) {
73 return false; 73 return false;
74 } 74 }
75 return true; 75 return true;
76 } 76 }
77 77
78 78
79 bool VirtualMemory::Protect(Protection mode) { 79 bool VirtualMemory::Protect(void* address, intptr_t size, Protection mode) {
80 uword start_address = reinterpret_cast<uword>(address);
81 uword end_address = start_address + size;
82 uword page_address = Utils::RoundDown(start_address, PageSize());
80 int prot = 0; 83 int prot = 0;
81 switch (mode) { 84 switch (mode) {
82 case kNoAccess: 85 case kNoAccess:
83 prot = PROT_NONE; 86 prot = PROT_NONE;
84 break; 87 break;
85 case kReadOnly: 88 case kReadOnly:
86 prot = PROT_READ; 89 prot = PROT_READ;
87 break; 90 break;
88 case kReadWrite: 91 case kReadWrite:
89 prot = PROT_READ | PROT_WRITE; 92 prot = PROT_READ | PROT_WRITE;
90 break; 93 break;
91 case kReadExecute: 94 case kReadExecute:
92 prot = PROT_READ | PROT_EXEC; 95 prot = PROT_READ | PROT_EXEC;
93 break; 96 break;
94 case kReadWriteExecute:
95 prot = PROT_READ | PROT_WRITE | PROT_EXEC;
96 break;
97 } 97 }
98 return (mprotect(address(), size(), prot) == 0); 98 return (mprotect(reinterpret_cast<void*>(page_address),
99 end_address - page_address,
100 prot) == 0);
99 } 101 }
100 102
103
101 } // namespace dart 104 } // namespace dart
102 105
103 #endif // defined(TARGET_OS_LINUX) 106 #endif // defined(TARGET_OS_LINUX)
OLDNEW
« no previous file with comments | « runtime/vm/virtual_memory_android.cc ('k') | runtime/vm/virtual_memory_macos.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698