Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(903)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1365613002: Rename PLACEHOLDER code kind to WASM_FUNCTION. (Closed)

Created:
5 years, 3 months ago by titzer
Modified:
5 years, 3 months ago
CC:
v8-reviews_googlegroups.com, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Rename PLACEHOLDER code kind to WASM_FUNCTION. R=mstarzinger@chromium.org BUG= Committed: https://crrev.com/3e4fb100f2bba80e202583ca3e18b51af822c56e Cr-Commit-Position: refs/heads/master@{#30893}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M src/log.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/objects.h View 1 chunk +1 line, -1 line 0 comments Download
M src/snapshot/serialize.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
titzer
5 years, 3 months ago (2015-09-23 13:00:03 UTC) #1
Michael Starzinger
LGTM.
5 years, 3 months ago (2015-09-23 13:14:28 UTC) #2
titzer
On 2015/09/23 13:14:28, Michael Starzinger wrote: > LGTM. +vogelheim for snapshot.
5 years, 3 months ago (2015-09-23 13:15:22 UTC) #4
vogelheim
lgtm
5 years, 3 months ago (2015-09-23 13:17:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1365613002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1365613002/1
5 years, 3 months ago (2015-09-23 14:44:36 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-23 15:08:34 UTC) #8
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 15:09:21 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/3e4fb100f2bba80e202583ca3e18b51af822c56e
Cr-Commit-Position: refs/heads/master@{#30893}

Powered by Google App Engine
This is Rietveld 408576698