infra/libs/service_utils/_daemon_win32.py - Issue 1365583002: Have service_manager start a cloudtail attached to each service it starts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: infra/libs/service_utils/_daemon_win32.py

Issue 1365583002: Have service_manager start a cloudtail attached to each service it starts. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master

Patch Set: Just use the default project ID Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« infra/libs/service_utils/_daemon_nix.py ('K') | « infra/libs/service_utils/_daemon_nix.py ('k') | infra/libs/service_utils/test/_daemon_nix_test.py » ('j') | infra/services/service_manager/__main__.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: infra/libs/service_utils/_daemon_win32.py

diff --git a/infra/libs/service_utils/_daemon_win32.py b/infra/libs/service_utils/_daemon_win32.py

index a59e964f08da29691ce9a3b2809c1ea3f0fca03f..629e7a4fe322efdaea4fc422926aff9b91d42a93 100644

--- a/infra/libs/service_utils/_daemon_win32.py

+++ b/infra/libs/service_utils/_daemon_win32.py

@@ -92,5 +92,9 @@ def add_timeout(_cmd, _timeout_secs): # pragma: no cover

raise NotImplementedError

+def close_all_fds(_keep_fds): # pragma: no cover

+ raise NotImplementedError

def become_daemon(_keep_fds=None): # pragma: no cover

raise NotImplementedError