pdf/pdf_engine.h - Issue 1365563003: Prevent guest views from issuing a search for empty text.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pdf/pdf_engine.h

Issue 1365563003: Prevent guest views from issuing a search for empty text. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: parens Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: pdf/pdf_engine.h

diff --git a/pdf/pdf_engine.h b/pdf/pdf_engine.h

index 69761a16b76cd691ba7727d79f6366b6260e26ea..7cde54aaf64e1f8cb965539ee9a5cf6940b47776 100644

--- a/pdf/pdf_engine.h

+++ b/pdf/pdf_engine.h

@@ -209,7 +209,7 @@ class PDFEngine {

uint32_t page_range_count,

const PP_PrintSettings_Dev& print_settings) = 0;

virtual void PrintEnd() = 0;

- virtual void StartFind(const char* text, bool case_sensitive) = 0;

+ virtual void StartFind(const std::string& text, bool case_sensitive) = 0;

virtual bool SelectFindResult(bool forward) = 0;

virtual void StopFind() = 0;

virtual void ZoomUpdated(double new_zoom_level) = 0;

« no previous file with comments | « pdf/out_of_process_instance.cc ('k') | pdf/pdfium/pdfium_engine.h » ('j') | no next file with comments »