content/public/browser/web_contents.h - Issue 1365563003: Prevent guest views from issuing a search for empty text.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/browser/web_contents.h

Issue 1365563003: Prevent guest views from issuing a search for empty text. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: parens Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/public/browser/web_contents.h

diff --git a/content/public/browser/web_contents.h b/content/public/browser/web_contents.h

index a0ea79fb0128b5e72d8f62f549b2761217f7655d..4e46d046d59e2de27e5c4bf51b69f619ddd5b290 100644

--- a/content/public/browser/web_contents.h

+++ b/content/public/browser/web_contents.h

@@ -640,7 +640,7 @@ class WebContents : public PageNavigator,

// removed since we can then embed iframes in different processes.

virtual bool IsSubframe() const = 0;

- // Finds text on a page.

+ // Finds text on a page. |search_text| should not be empty.

virtual void Find(int request_id,

const base::string16& search_text,

const blink::WebFindOptions& options) = 0;

« no previous file with comments | « content/browser/web_contents/web_contents_impl.cc ('k') | content/renderer/render_view_impl.cc » ('j') | no next file with comments »