Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(952)

Unified Diff: content/common/gpu/gpu_channel_manager_unittest.cc

Issue 1365563002: Make channel preemption not require view contexts for hookup (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@wakeup_gpu
Patch Set: rebase Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/common/gpu/gpu_channel_manager.cc ('k') | content/common/gpu/gpu_channel_test_common.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/common/gpu/gpu_channel_manager_unittest.cc
diff --git a/content/common/gpu/gpu_channel_manager_unittest.cc b/content/common/gpu/gpu_channel_manager_unittest.cc
index e8770e313931e8c4dc3c47c2bb1f5c0a727174c8..ddea0f185e70599bbdcf9bd11a2f92462c3f75bc 100644
--- a/content/common/gpu/gpu_channel_manager_unittest.cc
+++ b/content/common/gpu/gpu_channel_manager_unittest.cc
@@ -28,8 +28,15 @@ TEST_F(GpuChannelManagerTest, EstablishChannel) {
ASSERT_TRUE(channel_manager());
- EXPECT_TRUE(channel_manager()->OnMessageReceived(GpuMsg_EstablishChannel(
- kClientId, kClientTracingId, false, false, false)));
+ GpuMsg_EstablishChannel_Params params;
+ params.client_id = kClientId;
+ params.client_tracing_id = kClientTracingId;
+ params.preempts = false;
+ params.preempted = false;
+ params.allow_future_sync_points = false;
+ params.allow_real_time_streams = false;
+ EXPECT_TRUE(
+ channel_manager()->OnMessageReceived(GpuMsg_EstablishChannel(params)));
EXPECT_EQ((size_t)1, sink()->message_count());
const IPC::Message* msg =
sink()->GetUniqueMessageMatching(GpuHostMsg_ChannelEstablished::ID);
@@ -63,13 +70,22 @@ TEST_F(GpuChannelManagerTest, SecureValueStateForwarding) {
ASSERT_TRUE(channel_manager());
// Initialize gpu channels
- EXPECT_TRUE(channel_manager()->OnMessageReceived(GpuMsg_EstablishChannel(
- kClientId1, kClientTracingId1, false, false, false)));
+ GpuMsg_EstablishChannel_Params params;
+ params.client_id = kClientId1;
+ params.client_tracing_id = kClientTracingId1;
+ params.preempts = false;
+ params.preempted = false;
+ params.allow_future_sync_points = false;
+ params.allow_real_time_streams = false;
+ EXPECT_TRUE(
+ channel_manager()->OnMessageReceived(GpuMsg_EstablishChannel(params)));
GpuChannel* channel1 = channel_manager()->LookupChannel(kClientId1);
ASSERT_TRUE(channel1);
- EXPECT_TRUE(channel_manager()->OnMessageReceived(GpuMsg_EstablishChannel(
- kClientId2, kClientTracingId2, false, false, false)));
+ params.client_id = kClientId2;
+ params.client_tracing_id = kClientTracingId2;
+ EXPECT_TRUE(
+ channel_manager()->OnMessageReceived(GpuMsg_EstablishChannel(params)));
GpuChannel* channel2 = channel_manager()->LookupChannel(kClientId2);
ASSERT_TRUE(channel2);
« no previous file with comments | « content/common/gpu/gpu_channel_manager.cc ('k') | content/common/gpu/gpu_channel_test_common.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698