Issue 136553006: Add handling alpha values in RRGGBBAA formatted styles.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 136553006: Add handling alpha values in RRGGBBAA formatted styles. (Closed)

Created:
6 years, 11 months ago by jcgregorio

Modified:
6 years, 11 months ago

Reviewers:
robertphillips

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlesource.com/skia.git@master

Visibility:
Public.

More Reviews

Description

Add handling alpha values in RRGGBBAA formatted styles. BUG= Committed: http://code.google.com/p/skia/source/detail?r=13052

Patch Set 2 : typo #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -4 lines)			Patch
	M	experimental/SkV8Example/JsContext.cpp	View	1	2 chunks	+11 lines, -4 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

robertphillips

lgtm + typo https://codereview.chromium.org/136553006/diff/1/experimental/SkV8Example/JsContext.cpp File experimental/SkV8Example/JsContext.cpp (right): https://codereview.chromium.org/136553006/diff/1/experimental/SkV8Example/JsContext.cpp#newcode163 experimental/SkV8Example/JsContext.cpp:163: v8::String::NewFromUtf8( length?

6 years, 11 months ago (2014-01-13 17:49:55 UTC) #2

jcgregorio

https://codereview.chromium.org/136553006/diff/1/experimental/SkV8Example/JsContext.cpp File experimental/SkV8Example/JsContext.cpp (right): https://codereview.chromium.org/136553006/diff/1/experimental/SkV8Example/JsContext.cpp#newcode163 experimental/SkV8Example/JsContext.cpp:163: v8::String::NewFromUtf8( On 2014/01/13 17:49:56, robertphillips wrote: > length? Done.

6 years, 11 months ago (2014-01-13 17:52:41 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/jcgregorio@google.com/136553006/60001

6 years, 11 months ago (2014-01-13 17:52:57 UTC) #4

Message was sent while issue was closed.

Change committed as 13052

Expand Messages | Collapse Messages

Issue 136553006: Add handling alpha values in RRGGBBAA formatted styles. (Closed)

Description

Patch Set 1 #

Patch Set 2 : typo #

Messages