Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 136553004: Fix MESA cruft appearing in 8888 vs. gpu telemetry runs (Closed)

Created:
6 years, 11 months ago by robertphillips
Modified:
6 years, 11 months ago
Reviewers:
bsalomon
CC:
skia-review_googlegroups.com, rmistry
Visibility:
Public.

Description

When a picture lies about its size (i.e., claims to be 100x100 but only ever draws to 90x100) arbitrary pixel differences can appear in the undrawn portion. This is causing spurious differences to appear in the 8888 vs. gpu telemetry results. Committed: http://code.google.com/p/skia/source/detail?r=13084

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M tools/PictureRenderer.cpp View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
robertphillips
6 years, 11 months ago (2014-01-13 15:45:55 UTC) #1
robertphillips
ping
6 years, 11 months ago (2014-01-14 13:26:49 UTC) #2
robertphillips
ping
6 years, 11 months ago (2014-01-15 12:57:47 UTC) #3
bsalomon
On 2014/01/15 12:57:47, robertphillips wrote: > ping lgtm
6 years, 11 months ago (2014-01-15 14:30:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/robertphillips@google.com/136553004/1
6 years, 11 months ago (2014-01-15 14:38:51 UTC) #5
commit-bot: I haz the power
6 years, 11 months ago (2014-01-15 14:51:28 UTC) #6
Message was sent while issue was closed.
Change committed as 13084

Powered by Google App Engine
This is Rietveld 408576698