Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issue 136553002: cr: Print a list of closest matching targets when no match is found (Closed)

Created:
6 years, 11 months ago by Sami
Modified:
6 years, 11 months ago
Reviewers:
bulach, ian_cottrell
CC:
chromium-reviews
Visibility:
Public.

Description

cr: Print a list of closest matching targets when no match is found When the user passes in an invalid target name, print a list of closest matches as a hint: $ cr build chromium_test_shell Invalid target chromium_test_shell as chromium_test_shell Did you mean chromium_testshell, libchromiumtestshell or chromium_testshell_paks? NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244507

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M tools/cr/cr/actions/builder.py View 2 chunks +7 lines, -0 lines 0 comments Download
M tools/cr/cr/targets/target.py View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Sami
6 years, 11 months ago (2014-01-13 12:00:23 UTC) #1
bulach
lgtm, nice one, specially the chromium test shell and its infamous underscores :) loved the ...
6 years, 11 months ago (2014-01-13 15:17:39 UTC) #2
ian_cottrell
On 2014/01/13 15:17:39, bulach wrote: > lgtm, nice one, specially the chromium test shell and ...
6 years, 11 months ago (2014-01-13 15:38:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skyostil@chromium.org/136553002/1
6 years, 11 months ago (2014-01-13 15:44:50 UTC) #4
commit-bot: I haz the power
6 years, 11 months ago (2014-01-13 15:45:04 UTC) #5
Message was sent while issue was closed.
Change committed as 244507

Powered by Google App Engine
This is Rietveld 408576698