[MD settings] adding ClearFrom dropdown menu to ClearBrowsingData

[MD settings] adding ClearFrom dropdown menu to ClearBrowsingData

This CL adds a dropdown menu where the user may select
how far in the past they which to ClearBrowsingData.
e.g. 'the last hour' or 'the last week' and so on.

BUG=532739
Committed: https://crrev.com/c4fe16002ef903af7585a2d7b1c336655a47baf9
Cr-Commit-Position: refs/heads/master@{#350466}

[dschuyler, 2015-09-23 00:48:42]

dschuyler@chromium.org changed reviewers:
+ stevenjb@chromium.org

[stevenjb, 2015-09-23 15:52:35]

https://codereview.chromium.org/1365523002/diff/20001/chrome/browser/resource...
File
chrome/browser/resources/settings/clear_browsing_data_page/clear_browsing_data_page.html
(right):

https://codereview.chromium.org/1365523002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/clear_browsing_data_page/clear_browsing_data_page.html:14:
<paper-menu class="dropdown-content"
This looks like a good candidate for a wrapper similar to
cr-settings-radio-group, e.g.

<settings-dropdown-menu pref="{{prefs.browser.clear_data.time_period}}"
    items="[[clearFromOptions_]]">

That way we can add an indicator there too. However, since we are not doing any
pref conversion here, this seems fine for now.

https://codereview.chromium.org/1365523002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/clear_browsing_data_page/clear_browsing_data_page.html:17:
<paper-item>[[item]]</paper-item>
Hmm. Actually... isn't this going to set the value of the pref to the localized
string? Don't these need a value separate from the content?

[dschuyler, 2015-09-23 17:28:33]

https://codereview.chromium.org/1365523002/diff/20001/chrome/browser/resource...
File
chrome/browser/resources/settings/clear_browsing_data_page/clear_browsing_data_page.html
(right):

https://codereview.chromium.org/1365523002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/clear_browsing_data_page/clear_browsing_data_page.html:14:
<paper-menu class="dropdown-content"
On 2015/09/23 15:52:35, stevenjb wrote:
> This looks like a good candidate for a wrapper similar to
> cr-settings-radio-group, e.g.
> 
> <settings-dropdown-menu pref="{{prefs.browser.clear_data.time_period}}"
>     items="[[clearFromOptions_]]">
> 
> That way we can add an indicator there too. However, since we are not doing
any
> pref conversion here, this seems fine for now.

I went through the same thought process and conclusion :)

https://codereview.chromium.org/1365523002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/clear_browsing_data_page/clear_browsing_data_page.html:17:
<paper-item>[[item]]</paper-item>
On 2015/09/23 15:52:35, stevenjb wrote:
> Hmm. Actually... isn't this going to set the value of the pref to the
localized
> string? Don't these need a value separate from the content?

I had wondered that as well.  The selection is an index number, so this
directly useful.  (Which is quite nice).

[stevenjb, 2015-09-23 17:38:06]

lgtm w/ added comment

https://codereview.chromium.org/1365523002/diff/20001/chrome/browser/resource...
File
chrome/browser/resources/settings/clear_browsing_data_page/clear_browsing_data_page.html
(right):

https://codereview.chromium.org/1365523002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/clear_browsing_data_page/clear_browsing_data_page.html:17:
<paper-item>[[item]]</paper-item>
On 2015/09/23 17:28:33, dschuyler wrote:
> On 2015/09/23 15:52:35, stevenjb wrote:
> > Hmm. Actually... isn't this going to set the value of the pref to the
> localized
> > string? Don't these need a value separate from the content?
> 
> I had wondered that as well.  The selection is an index number, so this
> directly useful.  (Which is quite nice).

Ah, I see, so the pref is a number. We should add a comment in the HTML that the
order matches the pref store enumeration.

https://codereview.chromium.org/1365523002/diff/20001/chrome/browser/resource...
File
chrome/browser/resources/settings/clear_browsing_data_page/clear_browsing_data_page.js
(right):

https://codereview.chromium.org/1365523002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/clear_browsing_data_page/clear_browsing_data_page.js:42:
* List of options for the dropdown menu.
Add a comment that the order of these matches the pref store enum.

[dschuyler, 2015-09-23 18:07:08]

The CQ bit was checked by dschuyler@chromium.org

[dschuyler, 2015-09-23 18:07:08]

The patchset sent to the CQ was uploaded after l-g-t-m from
stevenjb@chromium.org
Link to the patchset: https://codereview.chromium.org/1365523002/#ps40001
(title: "review nit")

[commit-bot: I haz the power, 2015-09-23 18:12:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1365523002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1365523002/40001

[commit-bot: I haz the power, 2015-09-23 18:52:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-23 18:52:14]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[dschuyler, 2015-09-23 22:53:46]

The CQ bit was checked by dschuyler@chromium.org

[dschuyler, 2015-09-23 22:53:46]

The patchset sent to the CQ was uploaded after l-g-t-m from
stevenjb@chromium.org
Link to the patchset: https://codereview.chromium.org/1365523002/#ps60001
(title: "merge with master")

[dschuyler, 2015-09-23 23:45:17]

The CQ bit was unchecked by dschuyler@chromium.org

[dschuyler, 2015-09-23 23:45:21]

The CQ bit was checked by dschuyler@chromium.org

[dschuyler, 2015-09-24 00:10:53]

The CQ bit was unchecked by dschuyler@chromium.org

[dschuyler, 2015-09-24 00:43:49]

The CQ bit was checked by dschuyler@chromium.org

[commit-bot: I haz the power, 2015-09-24 01:02:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1365523002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1365523002/60001

[commit-bot: I haz the power, 2015-09-24 03:18:23]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-09-24 03:20:18]

Patchset 4 (id:??) landed as
https://crrev.com/c4fe16002ef903af7585a2d7b1c336655a47baf9
Cr-Commit-Position: refs/heads/master@{#350466}