Make NineImagePainter stay within the bounds rect.

Make NineImagePainter stay within the bounds rect.

This adds a check to handle the case where the bounds rect passed to Paint() is
too small to fully contain the border pieces.  In this case we skip the border
and fill the entire bounds rect with the center image.

This fixes visual glitches in scrollbar painting when the track is short (we
incorrectly paint a few pixels of track on top of the stepper buttons).

BUG=536234
Committed: https://crrev.com/bc49adcb8ffd054ed493b7025997d53fbfe27261
Cr-Commit-Position: refs/heads/master@{#351201}

[skobes, 2015-09-26 02:40:56]

skobes@chromium.org changed reviewers:
+ sky@chromium.org

[sky, 2015-09-28 15:01:36]

this happens if the space we're painting to is smaller than the needed size,
right? In that case should we just punt entirely? Taking the upper left corner
of each portion that will fit seems like it's going to look pretty crap.

[skobes, 2015-09-28 15:50:06]

On 2015/09/28 15:01:36, sky wrote:
> this happens if the space we're painting to is smaller than the needed size,
> right? In that case should we just punt entirely? Taking the upper left corner
> of each portion that will fit seems like it's going to look pretty crap.

We still need to fill the space or else whatever was behind it shows through.

I think for the Aura scrollbar track the border pieces are the same color as the
center so it doesn't matter which one we paint there.

Should we punt on the border and just paint the center?

[sky, 2015-09-28 17:56:54]

I like just painting the center.

On Mon, Sep 28, 2015 at 8:50 AM,  <skobes@chromium.org> wrote:
> On 2015/09/28 15:01:36, sky wrote:
>>
>> this happens if the space we're painting to is smaller than the needed
>> size,
>> right? In that case should we just punt entirely? Taking the upper left
>> corner
>> of each portion that will fit seems like it's going to look pretty crap.
>
>
> We still need to fill the space or else whatever was behind it shows
> through.
>
> I think for the Aura scrollbar track the border pieces are the same color as
> the
> center so it doesn't matter which one we paint there.
>
> Should we punt on the border and just paint the center?
>
> https://codereview.chromium.org/1365503007/

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[skobes, 2015-09-28 21:09:05]

PTAL

[sky, 2015-09-28 22:54:02]

LGTM

[skobes, 2015-09-28 23:22:23]

The CQ bit was checked by skobes@chromium.org

[commit-bot: I haz the power, 2015-09-28 23:22:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1365503007/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1365503007/20001

[commit-bot: I haz the power, 2015-09-28 23:30:25]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-09-28 23:31:49]

Patchset 2 (id:??) landed as
https://crrev.com/bc49adcb8ffd054ed493b7025997d53fbfe27261
Cr-Commit-Position: refs/heads/master@{#351201}