Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Side by Side Diff: src/full-codegen/arm/full-codegen-arm.cc

Issue 1365503005: [es6] Fix invalid ToString in implementation of ToName. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Meh! Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/full-codegen/arm64/full-codegen-arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_ARM 5 #if V8_TARGET_ARCH_ARM
6 6
7 #include "src/code-factory.h" 7 #include "src/code-factory.h"
8 #include "src/code-stubs.h" 8 #include "src/code-stubs.h"
9 #include "src/codegen.h" 9 #include "src/codegen.h"
10 #include "src/compiler.h" 10 #include "src/compiler.h"
(...skipping 3786 matching lines...) Expand 10 before | Expand all | Expand 10 after
3797 3797
3798 // Load the argument into r0 and convert it. 3798 // Load the argument into r0 and convert it.
3799 VisitForAccumulatorValue(args->at(0)); 3799 VisitForAccumulatorValue(args->at(0));
3800 3800
3801 Label convert, done_convert; 3801 Label convert, done_convert;
3802 __ JumpIfSmi(r0, &convert); 3802 __ JumpIfSmi(r0, &convert);
3803 STATIC_ASSERT(FIRST_NAME_TYPE == FIRST_TYPE); 3803 STATIC_ASSERT(FIRST_NAME_TYPE == FIRST_TYPE);
3804 __ CompareObjectType(r0, r1, r1, LAST_NAME_TYPE); 3804 __ CompareObjectType(r0, r1, r1, LAST_NAME_TYPE);
3805 __ b(ls, &done_convert); 3805 __ b(ls, &done_convert);
3806 __ bind(&convert); 3806 __ bind(&convert);
3807 ToStringStub stub(isolate()); 3807 __ Push(r0);
3808 __ CallStub(&stub); 3808 __ CallRuntime(Runtime::kToName, 1);
3809 __ bind(&done_convert); 3809 __ bind(&done_convert);
3810 context()->Plug(r0); 3810 context()->Plug(r0);
3811 } 3811 }
3812 3812
3813 3813
3814 void FullCodeGenerator::EmitToObject(CallRuntime* expr) { 3814 void FullCodeGenerator::EmitToObject(CallRuntime* expr) {
3815 ZoneList<Expression*>* args = expr->arguments(); 3815 ZoneList<Expression*>* args = expr->arguments();
3816 DCHECK_EQ(1, args->length()); 3816 DCHECK_EQ(1, args->length());
3817 3817
3818 // Load the argument into r0 and convert it. 3818 // Load the argument into r0 and convert it.
(...skipping 1434 matching lines...) Expand 10 before | Expand all | Expand 10 after
5253 DCHECK(interrupt_address == 5253 DCHECK(interrupt_address ==
5254 isolate->builtins()->OsrAfterStackCheck()->entry()); 5254 isolate->builtins()->OsrAfterStackCheck()->entry());
5255 return OSR_AFTER_STACK_CHECK; 5255 return OSR_AFTER_STACK_CHECK;
5256 } 5256 }
5257 5257
5258 5258
5259 } // namespace internal 5259 } // namespace internal
5260 } // namespace v8 5260 } // namespace v8
5261 5261
5262 #endif // V8_TARGET_ARCH_ARM 5262 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « no previous file | src/full-codegen/arm64/full-codegen-arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698