Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(483)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/KeyboardShortcuts.java

Issue 1365453004: Create a new custom class that handles keyboard shortcuts for Custom Tab (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: respond to comments Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/KeyboardShortcuts.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/KeyboardShortcuts.java b/chrome/android/java/src/org/chromium/chrome/browser/KeyboardShortcuts.java
index 8111d1355ddf2e6301061107cb12206e71fe0faf..c853efe7b85f49fa9ef6671d82348b84c7f20061 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/KeyboardShortcuts.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/KeyboardShortcuts.java
@@ -9,13 +9,9 @@ import android.view.KeyEvent;
import org.chromium.base.annotations.SuppressFBWarnings;
import org.chromium.chrome.R;
import org.chromium.chrome.browser.tab.Tab;
-import org.chromium.chrome.browser.tabmodel.TabCreatorManager.TabCreator;
import org.chromium.chrome.browser.tabmodel.TabModel;
-import org.chromium.chrome.browser.tabmodel.TabModel.TabLaunchType;
import org.chromium.chrome.browser.tabmodel.TabModelUtils;
import org.chromium.content.browser.ContentViewCore;
-import org.chromium.content_public.browser.LoadUrlParams;
-import org.chromium.ui.base.PageTransition;
/**
* Implements app-level keyboard shortcuts for ChromeTabbedActivity and DocumentActivity.
@@ -137,21 +133,6 @@ public class KeyboardShortcuts {
case CTRL | SHIFT | KeyEvent.KEYCODE_N:
activity.onMenuOrKeyboardAction(R.id.new_incognito_tab_menu_id, false);
return true;
- case CTRL | SHIFT | KeyEvent.KEYCODE_B:
- case CTRL | KeyEvent.KEYCODE_H:
- String url = keyCode == KeyEvent.KEYCODE_B
- ? UrlConstants.BOOKMARKS_URL
- : UrlConstants.HISTORY_URL;
- Tab currentTab = TabModelUtils.getCurrentTab(curModel);
- if (currentTab != null && isCurrentTabVisible) {
- currentTab.loadUrl(new LoadUrlParams(url, PageTransition.AUTO_BOOKMARK));
- } else {
- TabCreator tabCreator = activity.getCurrentTabCreator();
- if (tabCreator != null) {
- tabCreator.launchUrl(url, TabLaunchType.FROM_KEYBOARD);
- }
- }
- return true;
case ALT | KeyEvent.KEYCODE_F:
case KeyEvent.KEYCODE_BUTTON_Y:
activity.onMenuOrKeyboardAction(R.id.show_menu, false);
@@ -204,10 +185,16 @@ public class KeyboardShortcuts {
case KeyEvent.KEYCODE_BUTTON_X:
activity.onMenuOrKeyboardAction(R.id.focus_url_bar, false);
return true;
+ case CTRL | SHIFT | KeyEvent.KEYCODE_B:
+ activity.onMenuOrKeyboardAction(R.id.all_bookmarks_menu_id, false);
+ return true;
case KeyEvent.KEYCODE_BOOKMARK:
case CTRL | KeyEvent.KEYCODE_D:
activity.onMenuOrKeyboardAction(R.id.bookmark_this_page_id, false);
return true;
+ case CTRL | KeyEvent.KEYCODE_H:
+ activity.onMenuOrKeyboardAction(R.id.open_history_menu_id, false);
+ return true;
case CTRL | KeyEvent.KEYCODE_P:
activity.onMenuOrKeyboardAction(R.id.print_id, false);
return true;
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698