Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1365443004: DevTools: remove unnecessary asynchrony from isolated filesystem. (Closed)

Created:
5 years, 2 months ago by pfeldman
Modified:
5 years, 2 months ago
Reviewers:
dgozman
CC:
blink-reviews, yurys, pfeldman, devtools-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: remove unnecessary asynchrony from isolated filesystem. BUG=529471 Committed: https://crrev.com/c496054d86764aeb165001664f48a597a05eeed4 Cr-Commit-Position: refs/heads/master@{#351162}

Patch Set 1 #

Patch Set 2 : rebaselined #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -155 lines) Patch
M third_party/WebKit/Source/devtools/front_end/workspace/IsolatedFileSystem.js View 1 10 chunks +12 lines, -113 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/workspace/IsolatedFileSystemManager.js View 1 4 chunks +0 lines, -42 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
pfeldman
5 years, 2 months ago (2015-09-25 21:53:39 UTC) #2
dgozman
lgtm
5 years, 2 months ago (2015-09-25 23:06:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1365443004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1365443004/1
5 years, 2 months ago (2015-09-26 01:52:20 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/102821) mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 2 months ago (2015-09-26 01:53:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1365443004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1365443004/20001
5 years, 2 months ago (2015-09-28 17:22:05 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-09-28 21:21:10 UTC) #11
commit-bot: I haz the power
5 years, 2 months ago (2015-09-28 21:22:38 UTC) #12
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/c496054d86764aeb165001664f48a597a05eeed4
Cr-Commit-Position: refs/heads/master@{#351162}

Powered by Google App Engine
This is Rietveld 408576698