src/IceTargetLoweringX86Base.h - Issue 1365433004: Use three-address form of imul

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceTargetLoweringX86Base.h

Issue 1365433004: Use three-address form of imul (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Rebase to head. Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/IceTargetLoweringX86Base.h

diff --git a/src/IceTargetLoweringX86Base.h b/src/IceTargetLoweringX86Base.h

index d96aa4fec040dee0cfd7ef2e58400238735c2587..da190e0a5f4d43b2dd3bb5d75a07fa0591fc4808 100644

--- a/src/IceTargetLoweringX86Base.h

+++ b/src/IceTargetLoweringX86Base.h

@@ -428,6 +428,9 @@ protected:

void _imul(Variable *Dest, Operand *Src0) {

Context.insert(Traits::Insts::Imul::create(Func, Dest, Src0));

}

+ void _imul_imm(Variable *Dest, Operand *Src0, Constant *Imm) {

+ Context.insert(Traits::Insts::ImulImm::create(Func, Dest, Src0, Imm));

+ }

void _insertps(Variable *Dest, Operand *Src0, Operand *Src1) {

Context.insert(Traits::Insts::Insertps::create(Func, Dest, Src0, Src1));

}