Use three-address form of imul

src/IceAssemblerX86Base.h

 //===- subzero/src/IceAssemblerX86Base.h - base x86 assembler -*- C++ -*---===//
 //
 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 //
 // Modified by the Subzero authors.
 //
 //===----------------------------------------------------------------------===//
 //
@@ skipping 733 matching lines @@
 
   void imul(Type Ty, typename Traits::GPRRegister dst,
             typename Traits::GPRRegister src);
   void imul(Type Ty, typename Traits::GPRRegister reg, const Immediate &imm);
   void imul(Type Ty, typename Traits::GPRRegister reg,
             const typename Traits::Address &address);
 
   void imul(Type Ty, typename Traits::GPRRegister reg);
   void imul(Type Ty, const typename Traits::Address &address);
 
+  void imul_imm(Type Ty, typename Traits::GPRRegister dst,

[Jim Stichnoth, 2015/09/25 21:02:10]

I'm not adamant about this, but following the existing naming style in this
file, maybe these versions should be named imul() instead of imul_imm()?

(I don't have the same concern for the two ICE layers above this.)

[sehr, 2015/09/25 23:04:40]

Done.

+                typename Traits::GPRRegister src, const Immediate &imm);
+  void imul_imm(Type Ty, typename Traits::GPRRegister dst,
+                const typename Traits::Address &address, const Immediate &imm);
+
   void mul(Type Ty, typename Traits::GPRRegister reg);
   void mul(Type Ty, const typename Traits::Address &address);
 
   template <class T = Traits,
             typename = typename std::enable_if<!T::Is64Bit>::type>
   void incl(typename Traits::GPRRegister reg);
   void incl(const typename Traits::Address &address);
 
   template <class T = Traits,
             typename = typename std::enable_if<!T::Is64Bit>::type>
@@ skipping 302 matching lines @@
   emitUint8(0x66);
 }
 
 } // end of namespace X86Internal
 
 } // end of namespace Ice
 
 #include "IceAssemblerX86BaseImpl.h"
 
 #endif // SUBZERO_SRC_ICEASSEMBLERX86BASE_H