chrome/browser/ui/aura/accessibility/automation_manager_aura.cc - Issue 1365433002: Add setSelection function to automation API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/aura/accessibility/automation_manager_aura.cc

Issue 1365433002: Add setSelection function to automation API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@nobrailleautostartintests

Patch Set: rebase Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/automation_internal/automation_action_adapter.h ('K') | « chrome/browser/ui/aura/accessibility/automation_manager_aura.h ('k') | chrome/common/extensions/api/automation.idl » ('j') | chrome/common/extensions/api/automation.idl » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/aura/accessibility/automation_manager_aura.cc

diff --git a/chrome/browser/ui/aura/accessibility/automation_manager_aura.cc b/chrome/browser/ui/aura/accessibility/automation_manager_aura.cc

index b110a87fe1bf249169d93b1e9233840ad79b35d2..300769f5a9d9f71fbec782e2f24865455ecd9e27 100644

--- a/chrome/browser/ui/aura/accessibility/automation_manager_aura.cc

+++ b/chrome/browser/ui/aura/accessibility/automation_manager_aura.cc

@@ -101,9 +101,14 @@ void AutomationManagerAura::MakeVisible(int32 id) {

current_tree_->MakeVisible(id);

}

-void AutomationManagerAura::SetSelection(int32 id, int32 start, int32 end) {

+void AutomationManagerAura::SetSelection(int32 anchor_id,

+ int32 anchor_offset,

+ int32 focus_id,

+ int32 focus_offset) {

CHECK(enabled_);

- current_tree_->SetSelection(id, start, end);

+ if (anchor_id != focus_id)

+ return;

David Tseng 2015/09/23 17:57:41 NOTREACHED here, right?

+ current_tree_->SetSelection(anchor_id, anchor_offset, focus_offset);

}

void AutomationManagerAura::ShowContextMenu(int32 id) {