Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 136543008: Use the same handle for checking and duplicating in DuplicateHandleProxy (Closed)

Created:
6 years, 10 months ago by jschuh
Modified:
6 years, 10 months ago
Reviewers:
cpu_(ooo_6.6-7.5)
CC:
chromium-reviews
Visibility:
Public.

Description

Use the same handle for checking and duplicating in DuplicateHandleProxy BUG=338524 R=cpu@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250744 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250890

Patch Set 1 #

Total comments: 1

Patch Set 2 : removed extra argument #

Patch Set 3 : Fixed double handle close #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -6 lines) Patch
M sandbox/win/src/handle_dispatcher.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M sandbox/win/src/handle_policy.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M sandbox/win/src/handle_policy.cc View 1 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 19 (0 generated)
jschuh
PTAL
6 years, 10 months ago (2014-02-11 00:04:56 UTC) #1
cpu_(ooo_6.6-7.5)
https://codereview.chromium.org/136543008/diff/1/sandbox/win/src/handle_policy.cc File sandbox/win/src/handle_policy.cc (right): https://codereview.chromium.org/136543008/diff/1/sandbox/win/src/handle_policy.cc#newcode55 sandbox/win/src/handle_policy.cc:55: const ClientInfo& client_info, remove client info.
6 years, 10 months ago (2014-02-11 18:30:19 UTC) #2
cpu_(ooo_6.6-7.5)
lgtm
6 years, 10 months ago (2014-02-11 18:30:23 UTC) #3
jschuh
The CQ bit was checked by jschuh@chromium.org
6 years, 10 months ago (2014-02-11 19:08:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jschuh@chromium.org/136543008/110001
6 years, 10 months ago (2014-02-11 19:10:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jschuh@chromium.org/136543008/110001
6 years, 10 months ago (2014-02-11 21:25:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jschuh@chromium.org/136543008/110001
6 years, 10 months ago (2014-02-11 22:04:23 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-12 05:29:42 UTC) #8
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) ash_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=262263
6 years, 10 months ago (2014-02-12 05:29:43 UTC) #9
jschuh
The CQ bit was checked by jschuh@chromium.org
6 years, 10 months ago (2014-02-12 14:29:08 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jschuh@chromium.org/136543008/110001
6 years, 10 months ago (2014-02-12 14:29:35 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-12 17:21:41 UTC) #12
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=262499
6 years, 10 months ago (2014-02-12 17:21:42 UTC) #13
jschuh
The CQ bit was checked by jschuh@chromium.org
6 years, 10 months ago (2014-02-12 17:23:28 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jschuh@chromium.org/136543008/110001
6 years, 10 months ago (2014-02-12 17:24:53 UTC) #15
commit-bot: I haz the power
Change committed as 250744
6 years, 10 months ago (2014-02-12 17:39:46 UTC) #16
jschuh
The CQ bit was checked by jschuh@chromium.org
6 years, 10 months ago (2014-02-13 01:18:48 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jschuh@chromium.org/136543008/720001
6 years, 10 months ago (2014-02-13 01:19:42 UTC) #18
commit-bot: I haz the power
6 years, 10 months ago (2014-02-13 01:25:14 UTC) #19
Message was sent while issue was closed. 
Change committed as 250890

Powered by Google App Engine
This is Rietveld 408576698