Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(994)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1365353002: Add Lenovo OneKey Theater DLLs to troublesome dll list. (Closed)

Created:
5 years, 2 months ago by grt (UTC plus 2)
Modified:
5 years, 2 months ago
Reviewers:
jschuh, Will Harris
CC:
chromium-reviews, darin-cc_chromium.org, jam, rickyz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add Lenovo OneKey Theater DLLs to troublesome dll list. BUG=536056 R=jschuh@chromium.org Committed: https://crrev.com/197b8581c0214100434647399df2147cc02d3718 Cr-Commit-Position: refs/heads/master@{#350890}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M content/common/sandbox_win.cc View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
grt (UTC plus 2)
Do we make an effort to test things like this before shipping them?
5 years, 2 months ago (2015-09-25 18:00:27 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1365353002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1365353002/1
5 years, 2 months ago (2015-09-25 18:03:09 UTC) #3
Will Harris
owner rs lgtm
5 years, 2 months ago (2015-09-25 18:46:08 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-09-25 18:53:34 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1365353002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1365353002/1
5 years, 2 months ago (2015-09-25 19:27:48 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-25 19:39:25 UTC) #9
commit-bot: I haz the power
5 years, 2 months ago (2015-09-25 19:40:07 UTC) #10
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/197b8581c0214100434647399df2147cc02d3718
Cr-Commit-Position: refs/heads/master@{#350890}

Powered by Google App Engine
This is Rietveld 408576698