Ensure the viewport is always represented by the inner viewport layer.

Ensure the viewport is always represented by the inner viewport layer.

Previously the LayerTreeImpl's CurrentScrollingLayer could be either
the inner viewport or the outer viewport. It's clearer if it only ever
takes one of these values.

BUG=526462
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/a3f3a946c870e0d04e7f64049ac0ac3ddea24d24
Cr-Commit-Position: refs/heads/master@{#351155}

[tdresser, 2015-09-25 17:30:37]

tdresser@chromium.org changed reviewers:
+ bokan@chromium.org

[tdresser, 2015-09-25 17:30:38]

This has all the cleanup work described in the comment thread of
https://codereview.chromium.org/1306193006/.

[bokan, 2015-09-25 17:37:10]

Awesome, thanks! lgtm % one comment.

https://codereview.chromium.org/1365343002/diff/1/cc/trees/layer_tree_host_im...
File cc/trees/layer_tree_host_impl.cc (right):

https://codereview.chromium.org/1365343002/diff/1/cc/trees/layer_tree_host_im...
cc/trees/layer_tree_host_impl.cc:499: return CurrentlyScrollingLayer() ==
InnerViewportScrollLayer();
Could you keep the NULL check? If this ever gets called before we register
viewport layers we might have a bad time.

[tdresser, 2015-09-25 17:41:43]

tdresser@chromium.org changed reviewers:
+ aelias@chromium.org

[tdresser, 2015-09-25 17:41:43]

+aelias for OWNERS review.

https://codereview.chromium.org/1365343002/diff/1/cc/trees/layer_tree_host_im...
File cc/trees/layer_tree_host_impl.cc (right):

https://codereview.chromium.org/1365343002/diff/1/cc/trees/layer_tree_host_im...
cc/trees/layer_tree_host_impl.cc:499: return CurrentlyScrollingLayer() ==
InnerViewportScrollLayer();
On 2015/09/25 17:37:10, bokan wrote:
> Could you keep the NULL check? If this ever gets called before we register
> viewport layers we might have a bad time.

Done.

[aelias_OOO_until_Jul13, 2015-09-25 19:48:51]

lgtm

[tdresser, 2015-09-25 20:10:05]

The CQ bit was checked by tdresser@chromium.org

[tdresser, 2015-09-25 20:10:05]

The patchset sent to the CQ was uploaded after l-g-t-m from bokan@chromium.org
Link to the patchset: https://codereview.chromium.org/1365343002/#ps20001
(title: "Readd null check.")

[commit-bot: I haz the power, 2015-09-25 20:10:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1365343002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1365343002/20001

[commit-bot: I haz the power, 2015-09-25 20:23:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-25 20:23:33]

Try jobs failed on following builders:
  cast_shell_linux on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

[tdresser, 2015-09-25 20:29:32]

The CQ bit was checked by tdresser@chromium.org

[tdresser, 2015-09-25 20:29:32]

The patchset sent to the CQ was uploaded after l-g-t-m from bokan@chromium.org,
aelias@chromium.org
Link to the patchset: https://codereview.chromium.org/1365343002/#ps40001
(title: "Fix compile.")

[commit-bot: I haz the power, 2015-09-25 20:29:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1365343002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1365343002/40001

[commit-bot: I haz the power, 2015-09-25 21:11:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-25 21:11:52]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[tdresser, 2015-09-28 18:13:14]

The CQ bit was checked by tdresser@chromium.org

[tdresser, 2015-09-28 18:13:14]

The patchset sent to the CQ was uploaded after l-g-t-m from bokan@chromium.org,
aelias@chromium.org
Link to the patchset: https://codereview.chromium.org/1365343002/#ps60001
(title: "Fix unit test.")

[commit-bot: I haz the power, 2015-09-28 18:13:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1365343002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1365343002/60001

[commit-bot: I haz the power, 2015-09-28 18:57:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-28 18:57:15]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[tdresser, 2015-09-28 19:05:42]

The CQ bit was checked by tdresser@chromium.org

[tdresser, 2015-09-28 19:05:42]

The patchset sent to the CQ was uploaded after l-g-t-m from bokan@chromium.org,
aelias@chromium.org
Link to the patchset: https://codereview.chromium.org/1365343002/#ps80001
(title: "Fix more tests.")

[commit-bot: I haz the power, 2015-09-28 19:14:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1365343002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1365343002/80001

[commit-bot: I haz the power, 2015-09-28 21:15:46]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-09-28 21:17:38]

Patchset 5 (id:??) landed as
https://crrev.com/a3f3a946c870e0d04e7f64049ac0ac3ddea24d24
Cr-Commit-Position: refs/heads/master@{#351155}