Issue 136533002: Reland 244394 - Convert DomAutomationController from CppBoundClass to...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 136533002: Reland 244394 - Convert DomAutomationController from CppBoundClass to... (Closed)

Created:
6 years, 11 months ago by jochen (gone - plz use gerrit)

Modified:
6 years, 11 months ago

Reviewers:
Mike West

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Reland 244394 - Convert DomAutomationController from CppBoundClass to... The difference to the original CL is that the DAC is only installed into the main world. Original Review URL: https://codereview.chromium.org/131573003 BUG=297480 R=mkwst@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244488

Total comments: 1

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+107 lines, -188 lines)			Patch
M	content/renderer/dom_automation_controller.h	View		4 chunks	+34 lines, -41 lines	0 comments	Download
M	content/renderer/dom_automation_controller.cc	View		2 chunks	+68 lines, -130 lines	0 comments	Download
M	content/renderer/render_view_impl.h	View		2 chunks	+0 lines, -5 lines	0 comments	Download
M	content/renderer/render_view_impl.cc	View	1	1 chunk	+5 lines, -12 lines	0 comments	Download

Total messages: 4 (0 generated)

Mike West

LGTM, assuming I'm remembering operator binding correctly. :) It would be good to note in ...

6 years, 11 months ago (2014-01-13 11:41:34 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/136533002/90001

6 years, 11 months ago (2014-01-13 12:07:18 UTC) #3

jochen (gone - plz use gerrit)

6 years, 11 months ago (2014-01-13 12:08:04 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r244488 (presubmit successful).