runtime/vm/object.h - Issue 13653005: Prevent expensive and unnecessary error formatting in the case a bound check is

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/object.h

Issue 13653005: Prevent expensive and unnecessary error formatting in the case a bound check is (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/object.h

===================================================================

--- runtime/vm/object.h (revision 20936)

+++ runtime/vm/object.h (working copy)

@@ -3681,7 +3681,7 @@

void set_index(intptr_t value) const;

RawAbstractType* bound() const { return raw_ptr()->bound_; }

void set_bound(const AbstractType& value) const;

- void CheckBound(const AbstractType& bounded_type,

+ bool CheckBound(const AbstractType& bounded_type,

srdjan 2013/04/04 20:12:52 Please document what result means (true/false).

regis 2013/04/04 20:24:32 Done.

const AbstractType& upper_bound,

Error* malformed_error) const;

virtual intptr_t token_pos() const { return raw_ptr()->token_pos_; }

« no previous file with comments | « runtime/vm/class_finalizer.cc ('k') | runtime/vm/object.cc » ('j') | no next file with comments »